Skip to content

Commit 6393140

Browse files
committed
Rename func
1 parent 03033e1 commit 6393140

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

sharktuner/sharktuner/candidate_ordering.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ class TuningRecord:
133133
benchmark_rank_order: Optional[int] = None
134134

135135

136-
def init_tuning_records(
136+
def build_tuning_records_from_order(
137137
knobs: list[Optional[common.KnobAssignment]], sorted_order: list[int]
138138
) -> list[TuningRecord]:
139139
tuning_records: list[TuningRecord] = []

sharktuner/sharktuner/libtuner.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -846,8 +846,8 @@ def generate_candidate_specs(
846846
# Total number of configs = candidates generated + baseline.
847847
assert len(config_specs) == len(solutions) + 1
848848

849-
tuning_client.tuning_records = candidate_ordering.init_tuning_records(
850-
knobs, sorted_order
849+
tuning_client.tuning_records = (
850+
candidate_ordering.build_tuning_records_from_order(knobs, sorted_order)
851851
)
852852

853853
knob_assignments = [dispatch_tuner.get_knob_assignment(s) for s in solutions]

sharktuner/tests/candidate_ordering_test.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ def test_reorder_assignments(
159159
)
160160

161161

162-
def test_init_tuning_records(
162+
def test_build_tuning_records_from_order(
163163
sample_knobs: list[Optional[common.KnobAssignment]],
164164
) -> None:
165165
tr1 = candidate_ordering.TuningRecord(
@@ -178,7 +178,9 @@ def test_init_tuning_records(
178178
knob=sample_knobs[1],
179179
)
180180
sorted_order = [2, 0, 1]
181-
tuning_records = candidate_ordering.init_tuning_records(sample_knobs, sorted_order)
181+
tuning_records = candidate_ordering.build_tuning_records_from_order(
182+
sample_knobs, sorted_order
183+
)
182184

183185
assert tuning_records == [tr1, tr2, tr3]
184186

0 commit comments

Comments
 (0)