Small fix

Author: RattataKing

sharktuner/sharktuner/candidate_ordering.py

@@ -149,7 +149,7 @@ def init_tuning_records(
 
 def export_record_to_csv(
     objects: list[TuningRecord], dest_dir: Path, filename: str = "export.csv"
-) -> Path:
+) -> Optional[Path]:
     if not objects:
         return None
 
@@ -176,7 +176,7 @@ def export_record_to_csv(
                     headers.append(k)
         rows.append(row)
 
-    path = os.path.join(dest_dir, filename)
+    path = Path(os.path.join(dest_dir, filename))
     with open(path, "w", newline="", encoding="utf-8") as f:
         writer = csv.DictWriter(f, fieldnames=headers)
         writer.writeheader()

sharktuner/sharktuner/libtuner.py

@@ -1343,8 +1343,10 @@ def benchmark(
         for i, handler_res in enumerate(all_candidates_with_speedup, start=1):
             benchmark_res, speedup = handler_res
             cid, _, device_id = benchmark_res
-            bas = baseline_handler.get_average_result_us(device_id)
-            tuning_client.tuning_records[cid].baseline_benchmark_time_us = round(bas, 2)
+            baseline_res = baseline_handler.get_average_result_us(device_id)
+            tuning_client.tuning_records[cid].baseline_benchmark_time_us = (
+                round(baseline_res, 2) if baseline_res else None
+            )
             tuning_client.tuning_records[cid].benchmark_speedup = round(speedup, 5)
             tuning_client.tuning_records[cid].benchmark_rank_order = i
 

sharktuner/tests/candidate_ordering_test.py

@@ -138,7 +138,7 @@ def test_reorder_assignments(
         == expected_order
     )
 
-    knobs = [None, None, None]
+    knobs: list[Optional[common.KnobAssignment]] = [None, None, None]
     assert (
         candidate_ordering.reorder_assignments(
             target_info=target_info,
@@ -164,7 +164,6 @@ def test_init_tuning_records(
 ) -> None:
     sorted_order = [2, 0, 1]
     tuning_records = candidate_ordering.init_tuning_records(sample_knobs, sorted_order)
-    expected: list[candidate_ordering.TuningRecord] = []
 
     expected: list[candidate_ordering.TuningRecord] = [
         candidate_ordering.TuningRecord(