diff --git a/.github/workflows/ci-amdsharktank.yml b/.github/workflows/ci-amdsharktank.yml index 1c2b59a6992..c3681cf84fd 100644 --- a/.github/workflows/ci-amdsharktank.yml +++ b/.github/workflows/ci-amdsharktank.yml @@ -106,7 +106,6 @@ jobs: name: Coverage runs-on: ubuntu-24.04 needs: test - if: github.event.pull_request.number != 2677 # Skip for large PR that exceeds GitHub's 300-file diff limit permissions: pull-requests: write contents: write @@ -289,7 +288,7 @@ jobs: # Depends on other jobs to provide an aggregate job status. # TODO(#584): move test_with_data and test_integration to a pkgci integration test workflow? - ci_amdsharktank_summary: # TODO: rename to ci_amdsharktank_summary + ci_amdsharktank_summary: if: always() runs-on: ubuntu-24.04 needs: diff --git a/.github/workflows/ci-amdsharktuner.yml b/.github/workflows/ci-amdsharktuner.yml index fd804695961..9f4f66d5f77 100644 --- a/.github/workflows/ci-amdsharktuner.yml +++ b/.github/workflows/ci-amdsharktuner.yml @@ -96,7 +96,6 @@ jobs: name: Coverage runs-on: ubuntu-24.04 needs: test - if: github.event.pull_request.number != 2677 # Skip for large PR that exceeds GitHub's 300-file diff limit permissions: pull-requests: write contents: write diff --git a/shortfin/tests/host_cpu_system_test.py b/shortfin/tests/host_cpu_system_test.py index 346e5243eed..bd45f6e6191 100644 --- a/shortfin/tests/host_cpu_system_test.py +++ b/shortfin/tests/host_cpu_system_test.py @@ -20,8 +20,8 @@ def test_create_host_cpu_system_defaults(): assert len(ls.devices) > 0 -@pytest.mark.skip( - reason="IREE UNIMPLEMENTED: threadless donate-only executor mode not yet implemented with hostcpu_topology_max_group_count=2" +@pytest.mark.skipif( + sys.platform == "win32", reason="Windows fatal exception: access violation" ) def test_create_host_cpu_system_topology_nodes_all(): sc = sf.host.CPUSystemBuilder(