Skip to content

Conversation

@RattataKing
Copy link
Contributor

  • Added coverage git comment report to the test, mainly copied from ci-sharktank.yml
  • Polished some env variable

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@9726c06). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2672   +/-   ##
=======================================
  Coverage        ?   77.48%           
=======================================
  Files           ?      264           
  Lines           ?    25251           
  Branches        ?        0           
=======================================
  Hits            ?    19565           
  Misses          ?     5686           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RattataKing RattataKing requested a review from kuhar November 14, 2025 22:26
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right. Do you have a link to a successful run that demonstrates this works e2e?

@RattataKing RattataKing requested a review from kuhar November 17, 2025 22:37
@RattataKing
Copy link
Contributor Author

RattataKing commented Nov 17, 2025

This doesn't look right. Do you have a link to a successful run that demonstrates this works e2e?

RattataKing#2
RattataKing#3

@kuhar kuhar merged commit ad71497 into nod-ai:main Nov 18, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants