Skip to content

Commit b0809c2

Browse files
authored
Target Node.js v14 in appveyor.yml
- Tests in `.travis.yml` target Node.js v14. - Tests in `appveyor.yml` should also target Node.js v14. - Updates `engines` in `package.json` to Node.js >= 10. - Includes test-fixes by @addaleax. PR-URL: #45
1 parent eadcf5d commit b0809c2

File tree

4 files changed

+12
-7
lines changed

4 files changed

+12
-7
lines changed

appveyor.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ environment:
77
# node.js
88
- nodejs_version: "10"
99
- nodejs_version: "12"
10+
- nodejs_version: "14"
1011

1112
platform:
1213
- x86

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "ref-napi",
33
"description": "Turn Buffer instances into \"pointers\"",
44
"engines": {
5-
"node": ">= 6.0"
5+
"node": ">= 10.0"
66
},
77
"keywords": [
88
"native",

test/pointer.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,14 @@ describe('pointer', function() {
4343
parent = null;
4444
gc();
4545
setImmediate(() => {
46-
assert(parent_gc, '"parent" has not been garbage collected');
47-
gc();
4846
setImmediate(() => {
47+
assert(parent_gc, '"parent" has not been garbage collected');
48+
gc();
4949
setImmediate(() => {
50-
assert(child_gc, '"child" has not been garbage collected');
51-
done();
50+
setImmediate(() => {
51+
assert(child_gc, '"child" has not been garbage collected');
52+
done();
53+
});
5254
});
5355
});
5456
});

test/reinterpret.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,10 @@ describe('reinterpret()', function() {
5252
other = null;
5353
gc();
5454
setImmediate(() => {
55-
assert(otherGCd, '"other" has not been garbage collected');
56-
assert(origGCd, '"buf" has not been garbage collected');
55+
setImmediate(() => {
56+
assert(otherGCd, '"other" has not been garbage collected');
57+
assert(origGCd, '"buf" has not been garbage collected');
58+
});
5759
});
5860
});
5961
});

0 commit comments

Comments
 (0)