feat!: upgrade NAPI bindings to latest version (#34)

* chore: upgrade packages to latest

* chore: first attempt to GHA

* chore: change npm run test test to pass --expose-gc properly

* chore: Use Unref instead of Reset to avoid SEGFAULT

Since Node.js 20, the test `should invoke *all* callbacks from
different weak references` fails because of a SEGFAULT. After
debugging, it seems that the issue is that, after the first
Immediate Callback and the corresponding Reset call of ObjectInfo,
the destructor to this is called, invalidating the reference, and
SetImmediate accesses to invalid memory.

By using Unref, we ensure that `this` is only destructed after all
callbacks are actually called. This matches the expectations of
the constructor, where we trigger a new Ref().

* chore: Upgrade AppVeyor dependencies and node versions

Author: kmruiz

.github/workflows/ci.yaml

@@ -0,0 +1,43 @@
+name: CI
+on: [push, pull_request]
+
+jobs:
+  check:
+    strategy:
+      fail-fast: false
+      matrix:
+        node-version: ['18.x', '20.x', '22.x', '24.x']
+        runner: [ubuntu-22.04, ubuntu-latest, macos-latest, windows-latest]
+
+    runs-on: ${{ matrix.runner }}
+
+    steps:
+      - uses: actions/checkout@v5
+      - name: Use Node.js ${{ matrix['node-version'] }}
+        uses: actions/setup-node@v6
+        with:
+          node-version: ${{ matrix['node-version'] }}
+
+      - name: Install Clang
+        if: ${{ startsWith(matrix.runner, 'ubuntu-') }}
+        uses: egor-tensin/[email protected]
+
+      - name: Install dependencies
+        run: npm install --build-from-source
+
+      - name: Run tests
+        run: npm test
+
+      - name: Run prebuild x64
+        if: ${{ startsWith(matrix.runner, 'ubuntu-') }}
+        shell: bash
+        run: |
+          npm run prebuild --v8_enable_pointer_compression=false \
+                           --v8_enable_31bit_smis_on_64bit_arch=false
+
+      - name: Run prebuild i32
+        if: ${{ startsWith(matrix.runner, 'ubuntu-') }}
+        shell: bash
+        run: |
+          ARCH=ia32 npm run prebuild --v8_enable_pointer_compression=false \
+                                     --v8_enable_31bit_smis_on_64bit_arch=false

appveyor.yml

@@ -5,8 +5,10 @@ environment:
   # Test against these versions of Node.js and io.js
   matrix:
     # node.js
-    - nodejs_version: "10"
-    - nodejs_version: "12"
+    - nodejs_version: "18"
+    - nodejs_version: "20"
+    - nodejs_version: "22"
+    - nodejs_version: "24"
 
 platform:
   - x86
@@ -30,7 +32,7 @@ test_script:
   - npm test
 
 after_test:
-  - ps: If ($env:nodejs_version -eq "12") { npm run prebuild --v8_enable_pointer_compression=false --v8_enable_31bit_smis_on_64bit_arch=false }
+  - ps: npm run prebuild --v8_enable_pointer_compression=false --v8_enable_31bit_smis_on_64bit_arch=false
 
 # Don't actually build.
 build: off
@@ -51,4 +53,4 @@ deploy:
     auth_token: $(PREBUILD_GITHUB_TOKEN)
     on:
       appveyor_repo_tag: true
-      nodejs_version: "12"
+      nodejs_version: "24"

package.json

@@ -24,20 +24,20 @@
   },
   "main": "lib/weak.js",
   "scripts": {
-    "test": "nyc mocha --expose-gc",
+    "test": "nyc mocha --node-option=expose-gc",
     "install": "node-gyp-build",
     "prebuild": "prebuildify --napi --tag-armv --tag-uv",
     "prepack": "prebuildify-ci download && ([ $(ls prebuilds | wc -l) = '5' ] || (echo 'Some prebuilds are missing'; exit 1))"
   },
   "dependencies": {
-    "node-addon-api": "^3.0.0",
-    "node-gyp-build": "^4.2.1",
-    "setimmediate-napi": "^1.0.3"
+    "node-addon-api": "^8.5.0",
+    "node-gyp-build": "^4.8.4",
+    "setimmediate-napi": "^1.0.6"
   },
   "devDependencies": {
-    "mocha": "^7.1.1",
-    "nyc": "^15.0.0",
-    "prebuildify": "^3.0.4",
+    "mocha": "^11.1.0",
+    "nyc": "^17.1.0",
+    "prebuildify": "^6.0.1",
     "prebuildify-ci": "^1.0.5"
   }
 }

src/weakref.cc

@@ -21,7 +21,7 @@ class ObjectInfo : public ObjectWrap<ObjectInfo> {
     SetImmediate(Env(), [this]() {
       callback_.MakeCallback(Value(), {});
       callback_.Reset();
-      Reset();
+      Unref();
     });
   }