chore: tweaks, notes updates

Signed-off-by: Charlike Mike Reagent <[email protected]>

Author: tunnckoCore

package.json

@@ -1,6 +1,6 @@
 {
   "name": "formidable",
-  "version": "2.0.0-canary.20200129.3",
+  "version": "2.0.0-canary.20200129.4",
   "license": "MIT",
   "description": "A node.js module for parsing form data, especially file uploads.",
   "homepage": "https://github.com/node-formidable/node-formidable",

src/Formidable.js

@@ -218,12 +218,15 @@ class IncomingForm extends EventEmitter {
 
     // This MUST check exactly for undefined. You can not change it to !part.filename.
 
+    // todo: uncomment when switch tests to Jest
+    // console.log(part);
+
     // ? NOTE(@tunnckocore): no it can be any falsey value, it most probably depends on what's returned
     // from somewhere else. Where recently I changed the return statements
     // and such thing because code style
     // ? NOTE(@tunnckocore): or even better, if there is no mime, then it's for sure a field
-    // ? NOTE(@tunnckocore): filename is an empty string when a field
-    if ((part.filename !== '' && !part.filename) || !part.mime) {
+    // ? NOTE(@tunnckocore): filename is an empty string when a field?
+    if (!part.mime) {
       let value = '';
       const decoder = new StringDecoder(part.transferEncoding || this.encoding);
 

test/integration/test-json.js

@@ -6,15 +6,18 @@ const formidable = require('../../src/index');
 
 const testData = {
   numbers: [1, 2, 3, 4, 5],
-  nested: { key: 'value' },
+  nested: { key: 'val' },
 };
 
 const PORT = 13532;
 const server = http.createServer((req, res) => {
   const form = formidable();
 
   form.parse(req, (err, fields) => {
-    assert.deepEqual(fields, testData);
+    assert.deepStrictEqual(fields, {
+      numbers: [1, 2, 3, 4, 5],
+      nested: { key: 'val' },
+    });
 
     res.end();
     server.close();