Fix task rule creation #145

Author: deepy

src/main/kotlin/com/github/gradle/node/NodePlugin.kt

@@ -13,6 +13,7 @@ import com.github.gradle.node.yarn.task.YarnSetupTask
 import com.github.gradle.node.yarn.task.YarnTask
 import org.gradle.api.Plugin
 import org.gradle.api.Project
+import org.gradle.kotlin.dsl.create
 import org.gradle.kotlin.dsl.named
 import org.gradle.kotlin.dsl.register
 import java.io.File
@@ -59,7 +60,7 @@ class NodePlugin : Plugin<Project> {
         project.tasks.addRule("Pattern: \"npm_<command>\": Executes an NPM command.") {
             val taskName = this
             if (taskName.startsWith("npm_")) {
-                project.tasks.register<NpmTask>(taskName) {
+                project.tasks.create<NpmTask>(taskName) {
                     val tokens = taskName.split("_").drop(1) // all except first
                     npmCommand.set(tokens)
                     if (tokens.first().equals("run", ignoreCase = true)) {
@@ -74,7 +75,7 @@ class NodePlugin : Plugin<Project> {
         project.tasks.addRule("Pattern: \"yarn_<command>\": Executes an Yarn command.") {
             val taskName = this
             if (taskName.startsWith("yarn_")) {
-                project.tasks.register<YarnTask>(taskName).configure {
+                project.tasks.create<YarnTask>(taskName) {
                     val tokens = taskName.split("_").drop(1) // all except first
                     yarnCommand.set(tokens)
                     if (tokens.first().equals("run", ignoreCase = true)) {

src/test/groovy/com/github/gradle/node/npm/task/NpmRule_integTest.groovy

@@ -22,6 +22,26 @@ class NpmRule_integTest extends AbstractIntegTest {
         result.outcome == TaskOutcome.SUCCESS
     }
 
+   def 'can configure npm_ rule task'() {
+        given:
+        writeBuild('''
+            plugins {
+                id 'com.github.node-gradle.node'
+            }
+
+            npm_run_build {
+                doFirst { project.logger.info('configured') }
+            }
+        ''')
+        writeEmptyPackageJson()
+
+        when:
+        def result = buildTask('help')
+
+        then:
+        result.outcome == TaskOutcome.SUCCESS
+   }
+
     def 'can execute an npm module using npm_run_'() {
         given:
         writeBuild('''

src/test/groovy/com/github/gradle/node/yarn/task/YarnRule_integTest.groovy

@@ -42,4 +42,25 @@ class YarnRule_integTest extends AbstractIntegTest {
         result.task(":yarn_run_hello").outcome == TaskOutcome.SUCCESS
         result.output.contains("Hello world!")
     }
+
+    def 'can configure yarn_ rule task'() {
+        given:
+        writeBuild("""
+            plugins {
+                id 'com.github.node-gradle.node'
+            }
+
+            yarn_run_build {
+                doFirst { project.logger.info('configured') }
+            }
+        """)
+
+        copyResources("fixtures/yarn-rule/package.json", "package.json")
+
+        when:
+        def result = buildTask("help")
+
+        then:
+        result.outcome == TaskOutcome.SUCCESS
+    }
 }