Add 'shareSecurityToken' method

Author: 3y3

src/debug.cc

@@ -58,15 +58,18 @@ namespace nodex {
         if (expression.IsEmpty())
           RETURN(Undefined());
 
+        Local<Context> current_context = Isolate::GetCurrent()->GetCurrentContext();
         Local<Context> debug_context = v8::Debug::GetDebugContext();
 #if (NODE_MODULE_VERSION > 45)
         if (debug_context.IsEmpty()) {
           // Force-load the debug context.
-          v8::Debug::GetMirror(info.GetIsolate()->GetCurrentContext(), info[0]);
+          v8::Debug::GetMirror(current_context, New<Object>());
           debug_context = v8::Debug::GetDebugContext();
         }
-#endif
 
+        // Share security token
+        debug_context->SetSecurityToken(current_context->GetSecurityToken());
+#endif
         Context::Scope context_scope(debug_context);
 
         TryCatch tryCatch;
@@ -77,12 +80,39 @@ namespace nodex {
       };
 
       static NAN_METHOD(AllowNatives) {
+        // TODO: deprecate this useless method
         const char allow_natives_syntax[] = "--allow_natives_syntax";
         v8::V8::SetFlagsFromString(allow_natives_syntax, sizeof(allow_natives_syntax) - 1);
 
         RETURN(Undefined());
       }
 
+      static NAN_METHOD(ShareSecurityToken) {
+        Local<Context> current_context = info.GetIsolate()->GetCurrentContext();
+        Local<Context> debug_context = v8::Debug::GetDebugContext();
+#if (NODE_MODULE_VERSION > 45)
+        if (debug_context.IsEmpty()) {
+          // Force-load the debug context.
+          v8::Debug::GetMirror(current_context, New<Object>());
+          debug_context = v8::Debug::GetDebugContext();
+        }
+#endif
+        // Share security token
+        debug_context->SetSecurityToken(current_context->GetSecurityToken());
+      }
+
+      static NAN_METHOD(UnshareSecurityToken) {
+        Local<Context> current_context = info.GetIsolate()->GetCurrentContext();
+        Local<Context> debug_context = v8::Debug::GetDebugContext();
+#if (NODE_MODULE_VERSION > 45)
+        if (debug_context.IsEmpty()) {
+          // Force-load the debug context.
+          v8::Debug::GetMirror(current_context, New<Object>());
+          debug_context = v8::Debug::GetDebugContext();
+        }
+#endif
+        debug_context->UseDefaultSecurityToken();
+      }
     private:
       Debug() {}
       ~Debug() {}
@@ -97,6 +127,8 @@ namespace nodex {
     SetMethod(target, "sendCommand", Debug::SendCommand);
     SetMethod(target, "runScript", Debug::RunScript);
     SetMethod(target, "allowNatives", Debug::AllowNatives);
+    SetMethod(target, "shareSecurityToken", Debug::ShareSecurityToken);
+    SetMethod(target, "unshareSecurityToken", Debug::UnshareSecurityToken);
   }
 
   NODE_MODULE(debug, Initialize)

v8-debug.js

@@ -107,10 +107,14 @@ function V8Debug() {
   // After node 0.12.0 this function serves to allocate Debug Context
   // like a persistent value, that saves all our changes.
   this._setDebugEventListener();
+  // We need to share security token between current and debug context to
+  // get access to evaluation functions
+  this._shareSecurityToken();
   this._wrapDebugCommandProcessor();
 
   this.once('close', function() {
     this._unwrapDebugCommandProcessor();
+    this._unshareSecurityToken();
     this._unsetDebugEventListener();
     process.nextTick(function() {
       this.removeAllListeners();
@@ -130,6 +134,14 @@ V8Debug.prototype._unsetDebugEventListener = function() {
   Debug.setListener(null);
 };
 
+V8Debug.prototype._shareSecurityToken = function() {
+  binding.shareSecurityToken();
+};
+
+V8Debug.prototype._unshareSecurityToken = function() {
+  binding.unshareSecurityToken();
+};
+
 V8Debug.prototype._wrapDebugCommandProcessor = function() {
   var proto = this.get('DebugCommandProcessor.prototype');
   overrides.processDebugRequest_ = proto.processDebugRequest;