fix: Use to exit event instead of close (#13)

if child process has unclosed stdio, then the main process cannot resolve successfully

Author: lusyn

index.js

@@ -76,8 +76,8 @@ module.exports = function runScript(script, options, extraOptions) {
       reject(err);
     });
 
-    proc.on('close', code => {
-      debug('proc emit close: %s', code);
+    proc.on('exit', code => {
+      debug('proc emit exit: %s', code);
       if (isEnd) return;
       isEnd = true;
       clearTimeout(timeoutTimer);
@@ -102,8 +102,8 @@ module.exports = function runScript(script, options, extraOptions) {
       return resolve(stdio);
     });
 
-    proc.on('exit', code => {
-      debug('proc emit exit: %s', code);
+    proc.on('close', code => {
+      debug('proc emit close: %s', code);
     });
 
     if (typeof extraOptions.timeout === 'number' && extraOptions.timeout > 0) {

test/fixtures/child-process-with-unclosed-stdio.js

@@ -0,0 +1,24 @@
+'use strict';
+
+const path = require('path');
+const runScript = require('../../');
+const argv = process.argv.slice(2);
+
+(async () => {
+  if (argv[0] === undefined) {
+    runScript(`node ${path.join(__dirname, './child-process-with-unclosed-stdio.js')} child`);
+    await new Promise(resolve => {
+      setTimeout(resolve, 1000);
+    });
+    console.log('child finish');
+    process.exit();
+  } else if (argv[0] === 'child') {
+    // eslint-disable-next-line no-constant-condition
+    while (true) {
+      console.log('grandChild running');
+      await new Promise(resolve => {
+        setTimeout(resolve, 1000);
+      });
+    }
+  }
+})();

test/runscript.test.js

@@ -170,6 +170,14 @@ describe('runscript.test.js', () => {
     });
   });
 
+  it('should exit when child process has not closed stdio streams', () => {
+    return runScript(`node ${path.join(__dirname, 'fixtures/child-process-with-unclosed-stdio.js')}`, {
+      stdio: 'pipe',
+    }).then(stdio => {
+      assert(/child finish/.test(stdio.stdout.toString().trim()));
+    });
+  });
+
   if (process.platform === 'win32') {
     it('should run relative path .\\node_modules\\.bin\\autod', () => {
       return runScript('.\\node_modules\\.bin\\autod -V', {