fix: compatible with pool stats reading (#578)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Documentation**
  * Corrected a typographical error in the README.
* **Chores**
  * Updated Node.js versions tested in CI to version 24.
  * Updated test coverage script for Node.js 16 compatibility.
  * Enhanced clean script to clear TypeScript build cache.
  * Upgraded Vitest development dependency to version 3.2.4.
* Added polyfills to improve compatibility with Node.js environments
lacking certain web APIs.
* **Bug Fixes**
  * Improved compatibility with updated HTTP client pool structure.
* Enhanced test assertions with detailed failure messages for easier
debugging.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Author: fengmk2

.github/workflows/nodejs.yml

@@ -13,6 +13,6 @@ jobs:
     uses: node-modules/github-actions/.github/workflows/node-test.yml@master
     with:
       os: 'ubuntu-latest, macos-latest, windows-latest'
-      version: '16, 18, 20, 22, 23'
+      version: '16, 18, 20, 22, 24'
     secrets:
       CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

README.md

@@ -136,7 +136,7 @@ content-type: application/json
 }
 ```
 
-This exmaple can use `options.data` with `application/json` content type:
+This example can use `options.data` with `application/json` content type:
 
 ```js
 await request('https://example.com', {

package.json

@@ -39,9 +39,9 @@
     "test": "npm run lint -- --fix && vitest run",
     "test-keepalive": "cross-env TEST_KEEPALIVE_COUNT=50 vitest run --test-timeout 180000 keep-alive-header.test.ts",
     "test-node16": "node examples/httpclient.cjs && node examples/search_github.cjs && node examples/timing.cjs",
-    "cov": "cross-env NODE_OPTIONS='--require ./test/patch-structuredClone.cjs' vitest run --coverage",
+    "cov": "cross-env NODE_OPTIONS=\"--require ./test/patch-for-node16-18.cjs\" vitest run --coverage",
     "ci": "npm run lint && npm run cov && npm run prepublishOnly && npm pack && attw --pack",
-    "clean": "rm -rf dist",
+    "clean": "rm -rf dist && tsc -b --clean",
     "prepublishOnly": "npm run build"
   },
   "dependencies": {
@@ -74,11 +74,12 @@
     "iconv-lite": "^0.6.3",
     "proxy": "^1.0.2",
     "selfsigned": "^2.4.1",
+    "string.prototype.towellformed": "^1.0.2",
     "tar-stream": "^2.2.0",
     "tshy": "^3.0.0",
     "tshy-after": "^1.0.0",
     "typescript": "^5.0.4",
-    "vitest": "^3.0.2"
+    "vitest": "^3.2.4"
   },
   "engines": {
     "node": ">= 18.19.0"

src/HttpClient.ts

@@ -227,9 +227,11 @@ export class HttpClient extends EventEmitter {
       return poolStatsMap;
     }
     for (const [ key, ref ] of clients) {
-      const pool = typeof ref.deref === 'function' ? ref.deref() : ref as unknown as Pool;
-      const stats = pool?.stats;
+      const pool = (typeof ref.deref === 'function' ? ref.deref() : ref) as unknown as (Pool & { dispatcher: Pool });
+      // NOTE: pool become to { dispatcher: Pool } in undici@v7
+      const stats = pool?.stats ?? pool?.dispatcher?.stats;
       if (!stats) continue;
+
       poolStatsMap[key] = {
         connected: stats.connected,
         free: stats.free,

src/fetch.ts

@@ -114,9 +114,11 @@ export class FetchFactory {
       return poolStatsMap;
     }
     for (const [ key, ref ] of clients) {
-      const pool = typeof ref.deref === 'function' ? ref.deref() : ref as unknown as Pool;
-      const stats = pool?.stats;
+      const pool = (typeof ref.deref === 'function' ? ref.deref() : ref) as unknown as (Pool & { dispatcher: Pool });
+      // NOTE: pool become to { dispatcher: Pool } in undici@v7
+      const stats = pool?.stats ?? pool?.dispatcher?.stats;
       if (!stats) continue;
+
       poolStatsMap[key] = {
         connected: stats.connected,
         free: stats.free,

test/HttpClient.test.ts

@@ -326,7 +326,8 @@ describe('HttpClient.test.ts', () => {
 
       const response = await httpclient.request(_url);
       assert.equal(response.status, 200);
-      assert.equal(Object.keys(httpclient.getDispatcherPoolStats()).length, 1);
+      assert.equal(Object.keys(httpclient.getDispatcherPoolStats()).length, 1,
+        `dispatcher pool stats: ${JSON.stringify(httpclient.getDispatcherPoolStats())}`);
     });
 
     it('should check non-ip hostname with custom lookup', async () => {

test/fetch.test.ts

@@ -108,7 +108,7 @@ describe('fetch.test.ts', () => {
 
     const stats = FetchFactory.getDispatcherPoolStats();
     assert(stats);
-    assert(Object.keys(stats).length > 0);
+    assert(Object.keys(stats).length > 0, `dispatcher pool stats: ${JSON.stringify(stats)}`);
   });
 
   it('fetch request with post should work', async () => {

test/fixtures/socket_server.ts

@@ -2,6 +2,7 @@ import { createServer, Server } from 'node:http';
 
 const socketPathPrefix = '/tmp/urllib.unix.sock';
 let index = 0;
+
 export async function startServer(): Promise<{
   server: Server,
   url: string,

test/options.socketPath.test.ts

@@ -19,7 +19,7 @@ describe.skipIf(isWindows())('options.socketPath.test.ts', () => {
 
   afterAll(async () => {
     await close();
-    await server2.closeServer();
+    await server2?.closeServer();
   });
 
   it('should request socket successfully', async () => {

test/patch-for-node16-18.cjs

@@ -0,0 +1,18 @@
+// vitest require structuredClone
+if (!('structuredClone' in globalThis)) {
+  const structuredClone = require('@ungap/structured-clone').default;
+
+  globalThis.structuredClone = structuredClone;
+  // console.debug('patched structuredClone for Node.js %s', process.version);
+}
+
+// vitest require crypto.getRandomValues
+const crypto = require('node:crypto');
+if (typeof crypto.getRandomValues !== 'function') {
+  crypto.getRandomValues = crypto.webcrypto.getRandomValues.bind(crypto.webcrypto);
+}
+
+// undici@v7 require String.prototype.toWellFormed, patch on Node.js 16 and 18
+if (typeof String.prototype.toWellFormed !== 'function') {
+  require('string.prototype.towellformed/auto');
+}