Skip to content

Commit 67e0d23

Browse files
knollearyknolleary
committed
Update tests to actually test boolean values
1 parent 051251c commit 67e0d23

File tree

10 files changed

+43
-43
lines changed

10 files changed

+43
-43
lines changed

‎test/lib/commands/disable_spec.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,14 @@ describe("commands/disable", function() {
4949
if (error) {
5050
throw error;
5151
}
52-
result.logList.called.should.be.true;
52+
result.logList.called.should.be.true();
5353
done();
5454
}).otherwise(done);
5555
});
5656

5757
it('displays command help if node not specified', function(done) {
5858
command({_:{}},result);
59-
result.help.called.should.be.true;
59+
result.help.called.should.be.true();
6060
done();
6161
});
6262
});

‎test/lib/commands/enable_spec.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,14 @@ describe("commands/enable", function() {
4949
if (error) {
5050
throw error;
5151
}
52-
result.logList.called.should.be.true;
52+
result.logList.called.should.be.true();
5353
done();
5454
}).otherwise(done);
5555
});
5656

5757
it('displays command help if node not specified', function(done) {
5858
command({_:{}},result);
59-
result.help.called.should.be.true;
59+
result.help.called.should.be.true();
6060
done();
6161
});
6262
});

‎test/lib/commands/hash_spec.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ describe("commands/hash-pw", function() {
4040
});
4141

4242
command({},result).then(function() {
43-
result.log.calledOnce.should.be.true;
43+
result.log.calledOnce.should.be.true();
4444
var hash = result.log.firstCall.args[0];
4545
bcrypt.compare("a-test-password",hash,function(err,match) {
4646
match.should.be.true
@@ -54,7 +54,7 @@ describe("commands/hash-pw", function() {
5454
});
5555

5656
command({},result).then(function() {
57-
result.log.called.should.be.false;
57+
result.log.called.should.be.false();
5858
done();
5959
});
6060
});
@@ -64,7 +64,7 @@ describe("commands/hash-pw", function() {
6464
});
6565

6666
command({},result).then(function() {
67-
result.log.called.should.be.false;
67+
result.log.called.should.be.false();
6868
done();
6969
});
7070
});

‎test/lib/commands/info_spec.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ describe("commands/info", function() {
4646
if (error) {
4747
throw error;
4848
}
49-
result.logDetails.called.should.be.true;
49+
result.logDetails.called.should.be.true();
5050
done();
5151
}).otherwise(done);
5252
});
@@ -66,16 +66,16 @@ describe("commands/info", function() {
6666
if (error) {
6767
throw error;
6868
}
69-
result.logDetails.called.should.be.false;
70-
result.warn.called.should.be.true;
69+
result.logDetails.called.should.be.false();
70+
result.warn.called.should.be.true();
7171
result.warn.args[0][0].should.eql("error");
7272
done();
7373
}).otherwise(done);
7474
});
7575

7676
it('displays command help if node not specified', function(done) {
7777
command({_:{}},result);
78-
result.help.called.should.be.true;
78+
result.help.called.should.be.true();
7979
done();
8080
});
8181

‎test/lib/commands/install_spec.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,14 @@ describe("commands/install", function() {
4949
if (error) {
5050
throw error;
5151
}
52-
result.logDetails.called.should.be.true;
52+
result.logDetails.called.should.be.true();
5353
done();
5454
}).otherwise(done);
5555
});
5656

5757
it('displays command help if node not specified', function(done) {
5858
command({_:{}},result);
59-
result.help.called.should.be.true;
59+
result.help.called.should.be.true();
6060
done();
6161
});
6262
});

‎test/lib/commands/list_spec.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ describe("commands/list", function() {
4444
if (error) {
4545
throw error;
4646
}
47-
result.logNodeList.called.should.be.true;
47+
result.logNodeList.called.should.be.true();
4848
done();
4949
}).otherwise(done);
5050
});

‎test/lib/commands/login_spec.js‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ describe("commands/list", function() {
5454

5555

5656
command({},result).then(function() {
57-
requestStub.calledTwice.should.be.true;
57+
requestStub.calledTwice.should.be.true();
5858
requestStub.args[0][0].should.eql("/auth/login");
5959
requestStub.args[1][0].should.eql("/auth/token");
6060
requestStub.args[1][1].should.eql({
@@ -63,11 +63,11 @@ describe("commands/list", function() {
6363
});
6464

6565

66-
config.tokens.calledTwice.should.be.true;
66+
config.tokens.calledTwice.should.be.true();
6767
should.not.exist(config.tokens.args[0][0]);
6868
config.tokens.args[1][0].should.eql({access_token:"12345"});
6969

70-
/Logged in/.test(result.log.args[0][0]).should.be.true;
70+
/Logged in/.test(result.log.args[0][0]).should.be.true();
7171

7272
done();
7373
}).otherwise(done);
@@ -78,20 +78,20 @@ describe("commands/list", function() {
7878
requestStub.onCall(0).returns(when.resolve({type:"unknown"}));
7979
requestStub.onCall(1).returns(when.resolve({access_token:"12345"}));
8080
command({},result).then(function() {
81-
requestStub.calledOnce.should.be.true;
81+
requestStub.calledOnce.should.be.true();
8282
requestStub.args[0][0].should.eql("/auth/login");
83-
/Unsupported login type/.test(result.warn.args[0][0]).should.be.true;
83+
/Unsupported login type/.test(result.warn.args[0][0]).should.be.true();
8484
done();
8585
}).otherwise(done);
8686
});
8787
it('handles no authentication', function(done) {
8888
var requestStub = sinon.stub(request,"request");
8989
requestStub.onCall(0).returns(when.resolve({}));
9090
command({},result).then(function() {
91-
requestStub.calledOnce.should.be.true;
91+
requestStub.calledOnce.should.be.true();
9292
requestStub.args[0][0].should.eql("/auth/login");
93-
result.log.called.should.be.false;
94-
result.warn.called.should.be.false;
93+
result.log.called.should.be.false();
94+
result.warn.called.should.be.false();
9595
done();
9696
}).otherwise(done);
9797
});
@@ -100,12 +100,12 @@ describe("commands/list", function() {
100100
requestStub.onCall(0).returns(when.resolve({type:"credentials"}));
101101
requestStub.onCall(1).returns(when.reject());
102102
command({},result).then(function() {
103-
config.tokens.calledOnce.should.be.true;
103+
config.tokens.calledOnce.should.be.true();
104104
should.not.exist(config.tokens.args[0][0]);
105105

106-
result.log.called.should.be.false;
107-
result.warn.called.should.be.true;
108-
/Login failed/.test(result.warn.args[0][0]).should.be.true;
106+
result.log.called.should.be.false();
107+
result.warn.called.should.be.true();
108+
/Login failed/.test(result.warn.args[0][0]).should.be.true();
109109
done();
110110
}).otherwise(done);
111111
});
@@ -114,11 +114,11 @@ describe("commands/list", function() {
114114
var requestStub = sinon.stub(request,"request");
115115
requestStub.onCall(0).returns(when.reject());
116116
command({},result).then(function() {
117-
config.tokens.calledOnce.should.be.true;
117+
config.tokens.calledOnce.should.be.true();
118118
should.not.exist(config.tokens.args[0][0]);
119-
result.log.called.should.be.false;
120-
result.warn.called.should.be.true;
121-
/Login failed/.test(result.warn.args[0][0]).should.be.true;
119+
result.log.called.should.be.false();
120+
result.warn.called.should.be.true();
121+
/Login failed/.test(result.warn.args[0][0]).should.be.true();
122122
done();
123123
}).otherwise(done);
124124
});

‎test/lib/commands/remove_spec.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,14 @@ describe("commands/remove", function() {
4848
if (error) {
4949
throw error;
5050
}
51-
result.log.called.should.be.true;
51+
result.log.called.should.be.true();
5252
done();
5353
}).otherwise(done);
5454
});
5555

5656
it('displays command help if node not specified', function(done) {
5757
command({_:{}},result);
58-
result.help.called.should.be.true;
58+
result.help.called.should.be.true();
5959
done();
6060
});
6161
});

‎test/lib/commands/search_spec.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ describe("commands/install", function() {
6666
sinon.stub(httpRequest,"get").yields("testError",{statusCode:200},JSON.stringify({rows:[]}));
6767

6868
command({_:[null,"testnode"]},result).then(function() {
69-
result.log.called.should.be.false;
69+
result.log.called.should.be.false();
7070
result.warn.called.should.be.true();
7171
result.warn.args[0][0].should.eql("testError");
7272
done();
@@ -78,7 +78,7 @@ describe("commands/install", function() {
7878
sinon.stub(httpRequest,"get").yields(null,{statusCode:101},"testError");
7979

8080
command({_:[null,"testnode"]},result).then(function() {
81-
result.log.called.should.be.false;
81+
result.log.called.should.be.false();
8282
result.warn.called.should.be.true();
8383
result.warn.args[0][0].should.eql("101: testError");
8484
done();

‎test/lib/commands/target_spec.js‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,31 +39,31 @@ describe("commands/target", function() {
3939

4040
it('queries the target', function(done) {
4141
command({_:[]},result);
42-
config.target.called.should.be.true;
42+
config.target.called.should.be.true();
4343
config.target.args[0].should.have.lengthOf(0);
44-
result.log.called.should.be.true;
45-
/http\:\/\/test\.example\.com/.test(result.log.args[0][0]).should.be.true;
44+
result.log.called.should.be.true();
45+
/http\:\/\/test\.example\.com/.test(result.log.args[0][0]).should.be.true();
4646
done();
4747
});
4848

4949
it('sets the target', function(done) {
5050
command({_:[null,"http://newtarget.example.com"]},result);
51-
config.target.called.should.be.true;
51+
config.target.called.should.be.true();
5252
config.target.args[0][0].should.eql("http://newtarget.example.com");
53-
result.log.called.should.be.true;
54-
/http\:\/\/newtarget\.example\.com/.test(result.log.args[0][0]).should.be.true;
53+
result.log.called.should.be.true();
54+
/http\:\/\/newtarget\.example\.com/.test(result.log.args[0][0]).should.be.true();
5555
done();
5656
});
5757

5858
it('rejects non http targets', function(done) {
5959
command({_:[null,"ftp://newtarget.example.com"]},result);
60-
config.target.called.should.be.false;
61-
result.warn.called.should.be.true;
60+
config.target.called.should.be.false();
61+
result.warn.called.should.be.true();
6262
done();
6363
});
6464
it('strips trailing slash from target', function(done) {
6565
command({_:[null,"http://newtarget.example.com/"]},result);
66-
config.target.called.should.be.true;
66+
config.target.called.should.be.true();
6767
config.target.args[0][0].should.eql("http://newtarget.example.com");
6868
done();
6969
});

0 commit comments

Comments
 (0)