Skip to content

Commit a4d0358

Browse files
committed
Remove 'when' module
1 parent 5bb7bae commit a4d0358

File tree

10 files changed

+31
-38
lines changed

10 files changed

+31
-38
lines changed

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "node-red-admin",
3-
"version": "0.2.0",
3+
"version": "0.2.1",
44
"description": "The Node-RED admin command line interface",
55
"homepage": "http://nodered.org",
66
"bugs": {
@@ -28,12 +28,12 @@
2828
"test": "./node_modules/.bin/mocha "
2929
},
3030
"dependencies": {
31+
"axios": "0.19.2",
3132
"bcryptjs": "^2.4.3",
3233
"cli-table": "^0.3.1",
3334
"colors": "^1.4.0",
3435
"minimist": "^1.2.5",
35-
"read": "^1.0.7",
36-
"axios": "0.19.2"
36+
"read": "^1.0.7"
3737
},
3838
"devDependencies": {
3939
"grunt": "^1.0.4",

test/lib/commands/disable_spec.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ var command = require("../../../lib/commands/disable");
1818

1919
var should = require("should");
2020
var sinon = require("sinon");
21-
var when = require("when");
2221

2322
var request = require("../../../lib/request");
2423
var result = require("./result_helper");
@@ -43,15 +42,15 @@ describe("commands/disable", function() {
4342
} catch(err) {
4443
error = err;
4544
}
46-
return when.resolve([]);
45+
return Promise.resolve([]);
4746
});
4847
command({_:[null,"testnode"]},result).then(function() {
4948
if (error) {
5049
throw error;
5150
}
5251
result.logList.called.should.be.true();
5352
done();
54-
}).otherwise(done);
53+
}).catch(done);
5554
});
5655

5756
it('displays command help if node not specified', function(done) {

test/lib/commands/enable_spec.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ var command = require("../../../lib/commands/enable");
1818

1919
var should = require("should");
2020
var sinon = require("sinon");
21-
var when = require("when");
2221

2322
var request = require("../../../lib/request");
2423
var result = require("./result_helper");
@@ -43,15 +42,15 @@ describe("commands/enable", function() {
4342
} catch(err) {
4443
error = err;
4544
}
46-
return when.resolve([]);
45+
return Promise.resolve([]);
4746
});
4847
command({_:[null,"testnode"]},result).then(function() {
4948
if (error) {
5049
throw error;
5150
}
5251
result.logList.called.should.be.true();
5352
done();
54-
}).otherwise(done);
53+
}).catch(done);
5554
});
5655

5756
it('displays command help if node not specified', function(done) {

test/lib/commands/hash_spec.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ var prompt = require("../../../lib/prompt");
2020

2121
var should = require("should");
2222
var sinon = require("sinon");
23-
var when = require("when");
2423

2524

2625
var request = require("../../../lib/request");

test/lib/commands/info_spec.js

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ var command = require("../../../lib/commands/info");
1818

1919
var should = require("should");
2020
var sinon = require("sinon");
21-
var when = require("when");
2221

2322
var request = require("../../../lib/request");
2423
var result = require("./result_helper");
@@ -30,7 +29,7 @@ describe("commands/info", function() {
3029
}
3130
result.reset();
3231
});
33-
32+
3433
it('displays information on a module', function(done) {
3534
var error;
3635
sinon.stub(request,"request",function(path,opts) {
@@ -40,17 +39,17 @@ describe("commands/info", function() {
4039
} catch(err) {
4140
error = err;
4241
}
43-
return when.resolve([]);
42+
return Promise.resolve([]);
4443
});
4544
command({_:[null,"testnode"]},result).then(function() {
4645
if (error) {
4746
throw error;
4847
}
4948
result.logDetails.called.should.be.true();
5049
done();
51-
}).otherwise(done);
50+
}).catch(done);
5251
});
53-
52+
5453
it('reports error', function(done) {
5554
var error;
5655
sinon.stub(request,"request",function(path,opts) {
@@ -60,7 +59,7 @@ describe("commands/info", function() {
6059
} catch(err) {
6160
error = err;
6261
}
63-
return when.reject("error");
62+
return Promise.reject("error");
6463
});
6564
command({_:[null,"testnode"]},result).then(function() {
6665
if (error) {
@@ -70,13 +69,13 @@ describe("commands/info", function() {
7069
result.warn.called.should.be.true();
7170
result.warn.args[0][0].should.eql("error");
7271
done();
73-
}).otherwise(done);
72+
}).catch(done);
7473
});
75-
74+
7675
it('displays command help if node not specified', function(done) {
7776
command({_:{}},result);
7877
result.help.called.should.be.true();
7978
done();
8079
});
81-
80+
8281
});

test/lib/commands/install_spec.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ var command = require("../../../lib/commands/install");
1818

1919
var should = require("should");
2020
var sinon = require("sinon");
21-
var when = require("when");
2221

2322
var request = require("../../../lib/request");
2423
var result = require("./result_helper");
@@ -43,15 +42,15 @@ describe("commands/install", function() {
4342
} catch(err) {
4443
error = err;
4544
}
46-
return when.resolve([]);
45+
return Promise.resolve([]);
4746
});
4847
command({_:[null,"testnode"]},result).then(function() {
4948
if (error) {
5049
throw error;
5150
}
5251
result.logDetails.called.should.be.true();
5352
done();
54-
}).otherwise(done);
53+
}).catch(done);
5554
});
5655

5756
it('displays command help if node not specified', function(done) {

test/lib/commands/list_spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,15 @@ describe("commands/list", function() {
3838
} catch(err) {
3939
error = err;
4040
}
41-
return when.resolve([]);
41+
return Promise.resolve([]);
4242
});
4343
command({},result).then(function() {
4444
if (error) {
4545
throw error;
4646
}
4747
result.logNodeList.called.should.be.true();
4848
done();
49-
}).otherwise(done);
49+
}).catch(done);
5050
});
5151

5252
});

test/lib/commands/remove_spec.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ var command = require("../../../lib/commands/remove");
1818

1919
var should = require("should");
2020
var sinon = require("sinon");
21-
var when = require("when");
2221

2322
var request = require("../../../lib/request");
2423
var result = require("./result_helper");
@@ -30,7 +29,7 @@ describe("commands/remove", function() {
3029
}
3130
result.reset();
3231
});
33-
32+
3433
it('removes a node', function(done) {
3534
var error;
3635
sinon.stub(request,"request",function(path,opts) {
@@ -42,17 +41,17 @@ describe("commands/remove", function() {
4241
} catch(err) {
4342
error = err;
4443
}
45-
return when.resolve([]);
44+
return Promise.resolve([]);
4645
});
4746
command({_:[null,"testnode"]},result).then(function() {
4847
if (error) {
4948
throw error;
5049
}
5150
result.log.called.should.be.true();
5251
done();
53-
}).otherwise(done);
52+
}).catch(done);
5453
});
55-
54+
5655
it('displays command help if node not specified', function(done) {
5756
command({_:{}},result);
5857
result.help.called.should.be.true();

test/lib/commands/result_helper.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ module.exports = {
2424
logList: sinon.spy(),
2525
logNodeList: sinon.spy(),
2626
logDetails: sinon.spy(),
27-
27+
2828
reset: function() {
2929
module.exports.log.reset();
3030
module.exports.warn.reset();

test/lib/commands/target_spec.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ var command = require("../../../lib/commands/target");
1818

1919
var should = require("should");
2020
var sinon = require("sinon");
21-
var when = require("when");
2221

2322
var config = require("../../../lib/config");
2423

@@ -36,7 +35,7 @@ describe("commands/target", function() {
3635
result.reset();
3736
config.target.restore();
3837
});
39-
38+
4039
it('queries the target', function(done) {
4140
command({_:[]},result);
4241
config.target.called.should.be.true();
@@ -45,7 +44,7 @@ describe("commands/target", function() {
4544
/http\:\/\/test\.example\.com/.test(result.log.args[0][0]).should.be.true();
4645
done();
4746
});
48-
47+
4948
it('sets the target', function(done) {
5049
command({_:[null,"http://newtarget.example.com"]},result);
5150
config.target.called.should.be.true();
@@ -54,7 +53,7 @@ describe("commands/target", function() {
5453
/http\:\/\/newtarget\.example\.com/.test(result.log.args[0][0]).should.be.true();
5554
done();
5655
});
57-
56+
5857
it('rejects non http targets', function(done) {
5958
command({_:[null,"ftp://newtarget.example.com"]},result);
6059
config.target.called.should.be.false();
@@ -67,8 +66,8 @@ describe("commands/target", function() {
6766
config.target.args[0][0].should.eql("http://newtarget.example.com");
6867
done();
6968
});
70-
71-
72-
73-
69+
70+
71+
72+
7473
});

0 commit comments

Comments
 (0)