Skip to content

Commit 393a433

Browse files
authored
Fix custom miminal build (#290)
Also bump default NodeJS version to 14 for custom builds
1 parent 4f71101 commit 393a433

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

docker-custom/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,11 @@ The `docker-alpine.sh` and `docker-debian.sh` are helper scripts to build a cust
3232
Change the build arguments as needed:
3333

3434
- `--build-arg ARCH=amd64` : architecture your are building for (arm32v6, arm32v7, arm64v8, amd64)
35-
- `--build-arg NODE_VERSION=10` : NodeJS version you like to use
35+
- `--build-arg NODE_VERSION=14` : NodeJS version you like to use
3636
- `--build-arg NODE_RED_VERSION=${NODE_RED_VERSION}` : don't change this, ${NODE_RED_VERSION} gets populated from package.json
3737
- `--build-arg OS=alpine` : the linux distro to use (alpine)
3838
- `--build-arg BUILD_DATE="$(date +"%Y-%m-%dT%H:%M:%SZ")"` : don't change this
39-
- `--build-arg TAG_SUFFIX=default` : to build the default or minimal image
39+
- `--build-arg TAG_SUFFIX=default` : to build the default or minimal image (only applies to the alpine build)
4040
- `--file Dockerfile.custom` : Dockerfile to use to build your image.
4141
- `--tag testing:node-red-build` : set the image name and tag
4242

docker-custom/docker-alpine.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ echo "#########################################################################"
77

88
docker build --rm --no-cache \
99
--build-arg ARCH=amd64 \
10-
--build-arg NODE_VERSION=12 \
10+
--build-arg NODE_VERSION=14 \
1111
--build-arg NODE_RED_VERSION=${NODE_RED_VERSION} \
1212
--build-arg OS=alpine \
1313
--build-arg BUILD_DATE="$(date +"%Y-%m-%dT%H:%M:%SZ")" \

docker-custom/docker-debian.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ echo "#########################################################################"
77

88
docker build --rm --no-cache \
99
--build-arg ARCH=amd64 \
10-
--build-arg NODE_VERSION=12 \
10+
--build-arg NODE_VERSION=14 \
1111
--build-arg NODE_RED_VERSION=${NODE_RED_VERSION} \
1212
--build-arg OS=buster-slim \
1313
--build-arg BUILD_DATE="$(date +"%Y-%m-%dT%H:%M:%SZ")" \

docker-custom/scripts/install_devtools.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
set -ex
33

44
# Installing Devtools
5-
if [[ ${TAG_SUFFIX} != "-minimal" ]]; then
5+
if [[ ${TAG_SUFFIX} != *"minimal" ]]; then
66
echo "Installing devtools"
77
apk add --no-cache --virtual devtools build-base linux-headers udev python2 python3
88
else

0 commit comments

Comments
 (0)