Minor cleanups

Author: cjbarth

src/signed-xml.ts

@@ -1094,8 +1094,7 @@ export class SignedXml {
       return;
     }
 
-    prefix = prefix || "";
-    const prefixed = prefix ? `${prefix}:` : prefix;
+    const currentPrefix = prefix ? `${prefix}:` : "";
     const signatureNamespace = "http://www.w3.org/2000/09/xmldsig#";
 
     // Find the SignedInfo element to append to
@@ -1112,9 +1111,9 @@ export class SignedXml {
         ref.xpath ?? "",
         doc,
         this.namespaceResolver,
-      ) as Element[];
+      );
 
-      if (!nodes.length) {
+      if (!utils.isArrayHasLength(nodes)) {
         throw new Error(
           `the following xpath cannot be signed because it was not found: ${ref.xpath}`,
         );
@@ -1168,7 +1167,7 @@ export class SignedXml {
         // Create the reference element directly using DOM methods to avoid namespace issues
         const referenceElem = signatureDoc.createElementNS(
           signatureNamespace,
-          `${prefixed}Reference`,
+          `${currentPrefix}Reference`,
         );
         referenceElem.setAttribute("URI", targetUri);
 
@@ -1182,14 +1181,14 @@ export class SignedXml {
 
         const transformsElem = signatureDoc.createElementNS(
           signatureNamespace,
-          `${prefixed}Transforms`,
+          `${currentPrefix}Transforms`,
         );
 
         for (const trans of ref.transforms || []) {
           const transform = this.findCanonicalizationAlgorithm(trans);
           const transformElem = signatureDoc.createElementNS(
             signatureNamespace,
-            `${prefixed}Transform`,
+            `${currentPrefix}Transform`,
           );
           transformElem.setAttribute("Algorithm", transform.getAlgorithmName());
 
@@ -1216,13 +1215,13 @@ export class SignedXml {
 
         const digestMethodElem = signatureDoc.createElementNS(
           signatureNamespace,
-          `${prefixed}DigestMethod`,
+          `${currentPrefix}DigestMethod`,
         );
         digestMethodElem.setAttribute("Algorithm", digestAlgorithm.getAlgorithmName());
 
         const digestValueElem = signatureDoc.createElementNS(
           signatureNamespace,
-          `${prefixed}DigestValue`,
+          `${currentPrefix}DigestValue`,
         );
         digestValueElem.textContent = digestAlgorithm.getHash(canonXml);
 
@@ -1372,10 +1371,7 @@ export class SignedXml {
     }
     const transform = this.findCanonicalizationAlgorithm(this.canonicalizationAlgorithm);
     const algo = this.findSignatureAlgorithm(this.signatureAlgorithm);
-    let currentPrefix;
-
-    currentPrefix = prefix || "";
-    currentPrefix = currentPrefix ? `${currentPrefix}:` : currentPrefix;
+    const currentPrefix = prefix ? `${prefix}:` : "";
 
     let res = `<${currentPrefix}SignedInfo>`;
     res += `<${currentPrefix}CanonicalizationMethod Algorithm="${transform.getAlgorithmName()}"`;