refactor: Algorithms constant, fix test, fix examples

Author: shunkica

example/new-api-example.js

@@ -1,7 +1,6 @@
 const fs = require("fs");
 const { XmlSignerFactory, XmlDSigValidator, Algorithms, pemToDer } = require("../lib/index");
 
-
 // Example XML to sign
 const xml = `<root>
   <data id="data1">Hello World</data>

src/algorithms.ts

@@ -41,4 +41,4 @@ export const Algorithms = {
   transform: TRANSFORM_ALGORITHMS,
   hash: HASH_ALGORITHMS,
   signature: SIGNATURE_ALGORITHMS,
-}
+};

src/signed-xml.ts

@@ -556,7 +556,7 @@ export class SignedXml {
       if (this.idAttributeQNames) {
         // idAttributeQNames supersede idAttributes
         for (const qName of this.idAttributeQNames) {
-          const [prefix, localName, namespaceURI] = utils.resolveQName(qName, this.namespaceMap);
+          const [, localName, namespaceURI] = utils.resolveQName(qName, this.namespaceMap);
           let tmp_elemXpath: string;
           if (namespaceURI) {
             tmp_elemXpath = `//*[@*[local-name(.)='${localName}' and namespace-uri(.)='${namespaceURI}']='${uri}']`;
@@ -571,8 +571,8 @@ export class SignedXml {
             if (num_elements_for_id > 1) {
               throw new Error(
                 "Cannot validate a document which contains multiple elements with the " +
-                "same value for the ID / Id / Id attributes, in order to prevent " +
-                "signature wrapping attack.",
+                  "same value for the ID / Id / Id attributes, in order to prevent " +
+                  "signature wrapping attack.",
               );
             }
 

src/xmldsig-validator.ts

@@ -1,7 +1,6 @@
 import type { KeyLike } from "crypto";
 import { DOMParser } from "@xmldom/xmldom";
 import { SignedXml } from "./signed-xml";
-import { BaseOptions } from "node:vm";
 
 const DEFAULT_ID_ATTRIBUTES = ["Id", "ID", "id"];
 const DEFAULT_MAX_TRANSFORMS = 4;

test/xml-validator.spec.ts

@@ -94,18 +94,8 @@ describe("XmlValidator", function () {
       });
       expect(validator).to.be.instanceOf(XmlDSigValidator);
     });
-
-    it("should throw error when neither publicCert nor getCertFromKeyInfo is provided", function () {
-      expect(() => {
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        new XmlDSigValidator({} as any);
-      }).to.throw(
-        "XmlValidator requires either a publicCert or getCertFromKeyInfo function in options.",
-      );
-    });
   });
 
-
   describe("validate", function () {
     it("should validate a valid signed XML document", function () {
       const xml = "<root><test>content</test></root>";
@@ -181,7 +171,7 @@ describe("XmlValidator", function () {
       const signedXml = createSignedXml(xml);
 
       const validator = new XmlDSigValidator({ publicCert });
-      
+
       // First validation
       const result1 = validator.validate(signedXml);
       expect(result1.valid).to.be.true;
@@ -254,10 +244,8 @@ describe("XmlValidator", function () {
       expect(() => validator.validate(xml)).to.throw();
     });
   });
-
 });
 
-
 describe("XmlValidator Security Features", function () {
   it("should prevent signature wrapping attacks by only returning signed content", function () {
     const xml = "<root><test>content</test><unsigned>malicious</unsigned></root>";