Added value to toc-checkbox; this should work cross-browser

Author: megoth

default-views/account/register-form.hbs

@@ -75,7 +75,7 @@
             {{#if tocUri}}
               <div class="checkbox">
                 <label>
-                  <input type="checkbox" name="acceptToc">
+                  <input type="checkbox" name="acceptToc" value="true">
                   I agree to the <a href="{{tocUri}}" target="_blank">Terms &amp; Conditions</a> of this service
                 </label>
               </div>

lib/requests/auth-request.js

@@ -88,7 +88,7 @@ class AuthRequest {
 
     let authQueryParams = AuthRequest.extractAuthParams(req)
     let returnToUrl = AuthRequest.parseParameter(req, 'returnToUrl')
-    const acceptToc = !!AuthRequest.parseParameter(req, 'acceptToc')
+    const acceptToc = AuthRequest.parseParameter(req, 'acceptToc') === 'true'
 
     let options = {
       response: res,

test/integration/account-creation-oidc-test.js

@@ -114,7 +114,7 @@ describe('AccountManager (OIDC account creation tests)', function () {
     it('should not create WebID if T&C is not accepted', (done) => {
       let subdomain = supertest('https://nicola.' + host)
       subdomain.post('/api/accounts/new')
-        .send('username=nicola&password=12345&acceptToc=false')
+        .send('username=nicola&password=12345&acceptToc=')
         .expect(400, done)
     })