Skip to content

Commit bc036be

Browse files
committed
Merge pull request #797 from solid/fix/no-github-deps
Test and fix global package installation
2 parents 689b941 + 3de987d commit bc036be

File tree

3 files changed

+26
-19
lines changed

3 files changed

+26
-19
lines changed

.travis.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,20 @@ addons:
1212
- nicola.localhost
1313

1414
before_install:
15+
- echo "No GitHub dependencies allowed" &&
16+
! grep '"github:' package-lock.json
1517
- npm install -g npm@latest
1618

1719
install:
1820
- npm ci
1921

2022
script:
23+
# Test the code
2124
- npm run standard
2225
- npm run nyc
26+
# Test global install of the package
27+
- npm pack .
28+
- npm install -g solid-server-*.tgz
2329

2430
after_success:
2531
- snyk monitor

package-lock.json

Lines changed: 19 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
"ip-range-check": "0.0.2",
5656
"is-ip": "^2.0.0",
5757
"li": "^1.0.1",
58-
"mashlib": "^0.7.12",
58+
"mashlib": "^0.7.13",
5959
"mime-types": "^2.1.11",
6060
"negotiator": "^0.6.0",
6161
"node-fetch": "^2.1.2",

0 commit comments

Comments
 (0)