Recognizes that apps have been registered via session

Author: jaxoncreed

src/handlers/login-consent-request.js

@@ -65,15 +65,18 @@ class LoginConsentRequest {
   static obtainConsent (consentRequest) {
     let { opAuthRequest, clientId } = consentRequest
 
+    const parsedAppOrigin = url.parse(consentRequest.opAuthRequest.params.redirect_uri)
+    const appOrigin = `${parsedAppOrigin.protocol}//${parsedAppOrigin.host}`
+
     // Consent for the local RP client (the home pod) is implied
-    if (consentRequest.isLocalRpClient(consentRequest)) {
+    if (consentRequest.isLocalRpClient(appOrigin)) {
       return Promise.resolve()
         .then(() => { consentRequest.markConsentSuccess(opAuthRequest) })
         .then(() => opAuthRequest)
     }
 
     // Check if user has submitted this from a Consent page
-    if (consentRequest.params.consent) {
+    if (consentRequest.hasAlreadyConsented(appOrigin)) {
       return consentRequest.saveConsentForClient(clientId)
         .then(() => { consentRequest.markConsentSuccess(opAuthRequest) })
         .then(() => opAuthRequest)
@@ -98,10 +101,13 @@ class LoginConsentRequest {
     return this.params['client_id']
   }
 
-  isLocalRpClient (request) {
-    const parsedAppOrigin = url.parse(request.opAuthRequest.params.redirect_uri)
-    const appOrigin = `${parsedAppOrigin.protocol}//${parsedAppOrigin.host}`
-    return request.opAuthRequest.req.app.locals.ldp.serverUri === appOrigin
+  isLocalRpClient (appOrigin) {
+    return this.opAuthRequest.req.app.locals.ldp.serverUri === appOrigin
+  }
+
+  hasAlreadyConsented (appOrigin) {
+    return this.opAuthRequest.req.session.consentedOrigins &&
+      this.opAuthRequest.req.session.consentedOrigins.includes(appOrigin)
   }
 
   checkSavedConsentFor (opAuthRequest) {
@@ -121,15 +127,15 @@ class LoginConsentRequest {
     let { opAuthRequest } = this
     let consentUrl = url.parse('/consent')
     consentUrl.query = opAuthRequest.req.query
-  
+
     consentUrl = url.format(consentUrl)
     opAuthRequest.subject = null
-  
+
     opAuthRequest.res.redirect(consentUrl)
-  
+
     this.signalResponseSent()
   }
-  
+
   signalResponseSent () {
     throw new AuthResponseSent('User redirected to login')
   }