Merge pull request then#84 from then/beat-bluebird

Beat bluebird

Author: ForbesLindesay

.gitignore

@@ -1,3 +1,4 @@
 components
 build
 node_modules
+/lib

Readme.md

@@ -5,6 +5,8 @@ This is a simple implementation of Promises.  It is a super set of ES6 Promises
 
 For detailed tutorials on its use, see www.promisejs.org
 
+**N.B.** This promise exposes internals via underscore (`_`) prefixed properties.  If you use these, your code will break with each new release.
+
 [![travis][travis-image]][travis-url]
 [![dep][dep-image]][dep-url]
 [![npm][npm-image]][npm-url]
@@ -170,55 +172,6 @@ function awesomeAPI(foo, bar, callback) {
 
 People who use typical node.js style callbacks will be able to just pass a callback and get the expected behavior.  The enlightened people can not pass a callback and will get awesome promises.
 
-## Extending Promises
-
-  There are three options for extending the promises created by this library.
-
-### Inheritance
-
-  You can use inheritance if you want to create your own complete promise library with this as your basic starting point, perfect if you have lots of cool features you want to add.  Here is an example of a promise library called `Awesome`, which is built on top of `Promise` correctly.
-
-```javascript
-var Promise = require('promise');
-function Awesome(fn) {
-  if (!(this instanceof Awesome)) return new Awesome(fn);
-  Promise.call(this, fn);
-}
-Awesome.prototype = Object.create(Promise.prototype);
-Awesome.prototype.constructor = Awesome;
-
-//Awesome extension
-Awesome.prototype.spread = function (cb) {
-  return this.then(function (arr) {
-    return cb.apply(this, arr);
-  })
-};
-```
-
-  N.B. if you fail to set the prototype and constructor properly or fail to do Promise.call, things can fail in really subtle ways.
-
-### Wrap
-
-  This is the nuclear option, for when you want to start from scratch.  It ensures you won't be impacted by anyone who is extending the prototype (see below).
-
-```javascript
-function Uber(fn) {
-  if (!(this instanceof Uber)) return new Uber(fn);
-  var _prom = new Promise(fn);
-  this.then = _prom.then;
-}
-
-Uber.prototype.spread = function (cb) {
-  return this.then(function (arr) {
-    return cb.apply(this, arr);
-  })
-};
-```
-
-### Extending the Prototype
-
-  In general, you should never extend the prototype of this promise implimenation because your extensions could easily conflict with someone elses extensions.  However, this organisation will host a library of extensions which do not conflict with each other, so you can safely enable any of those.  If you think of an extension that we don't provide and you want to write it, submit an issue on this repository and (if I agree) I'll set you up with a repository and give you permission to commit to it.
-
 ## License
 
   MIT

build.js

@@ -0,0 +1,50 @@
+'use strict';
+
+var fs = require('fs');
+var rimraf = require('rimraf');
+var acorn = require('acorn');
+var walk = require('acorn/dist/walk');
+
+var ids = [];
+var names = {};
+
+function getIdFor(name) {
+  if (name in names) return names[name];
+  var id;
+  do {
+    id = '_' + Math.floor(Math.random() * 100);
+  } while (ids.indexOf(id) !== -1)
+  ids.push(id);
+  names[name] = id;
+  return id;
+}
+
+function fixup(src) {
+  var ast = acorn.parse(src);
+  src = src.split('');
+  walk.simple(ast, {
+    MemberExpression: function (node) {
+      if (node.computed) return;
+      if (node.property.type !== 'Identifier') return;
+      if (node.property.name[0] !== '_') return;
+      replace(node.property, getIdFor(node.property.name));
+    }
+  });
+  function source(node) {
+    return src.slice(node.start, node.end).join('');
+  }
+  function replace(node, str) {
+    for (var i = node.start; i < node.end; i++) {
+      src[i] = '';
+    }
+    src[node.start] = str;
+  }
+  return src.join('');
+}
+rimraf.sync(__dirname + '/lib/');
+fs.mkdirSync(__dirname + '/lib/');
+fs.readdirSync(__dirname + '/src').forEach(function (filename) {
+  var src = fs.readFileSync(__dirname + '/src/' + filename, 'utf8');
+  var out = fixup(src);
+  fs.writeFileSync(__dirname + '/lib/' + filename, out);
+});

lib/core.js

@@ -4,7 +4,11 @@
   "description": "Bare bones Promises/A+ implementation",
   "main": "index.js",
   "scripts": {
-    "test": "mocha --timeout 200 --slow 99999 -R dot && npm run test-memory-leak",
+    "pretest": "node build",
+    "pretest-resolve": "node build",
+    "pretest-extensions": "node build",
+    "pretest-memory-leak": "node build",
+    "test": "mocha --bail --timeout 200 --slow 99999 -R dot && npm run test-memory-leak",
     "test-resolve": "mocha test/resolver-tests.js --timeout 200 --slow 999999",
     "test-extensions": "mocha test/extensions-tests.js --timeout 200 --slow 999999",
     "test-memory-leak": "node --expose-gc test/memory-leak.js"
@@ -16,9 +20,11 @@
   "author": "ForbesLindesay",
   "license": "MIT",
   "devDependencies": {
-    "promises-aplus-tests": "*",
+    "acorn": "^1.0.1",
     "better-assert": "*",
-    "mocha": "*"
+    "mocha": "*",
+    "promises-aplus-tests": "*",
+    "rimraf": "^2.3.2"
   },
   "dependencies": {
     "asap": "~2.0.1"