Skip to content

Commit 79167b0

Browse files
authored
set CITGM=true for undici (#1070)
1 parent c299fae commit 79167b0

File tree

3 files changed

+19
-17
lines changed

3 files changed

+19
-17
lines changed

lib/lookup.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,9 @@
440440
},
441441
"undici": {
442442
"prefix": "v",
443-
"maintainers": ["mcollina", "ronag"]
443+
"envVar": { "CITGM": true },
444+
"maintainers": ["mcollina", "ronag"],
445+
"comment": "skip a few tests that are too dependent on the network"
444446
},
445447
"uuid": {
446448
"prefix": "v",

test/reporter/test-reporter-junit.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,8 @@ test('reporter.junit(): failing', (t) => {
112112
}
113113

114114
junitReporter(logger, failingInput);
115-
t.equal(output, failingExpected),
116-
'we should get the expected output when a' + ' module fails';
115+
(t.equal(output, failingExpected),
116+
'we should get the expected output when a' + ' module fails');
117117
t.end();
118118
});
119119

@@ -138,8 +138,8 @@ test('reporter.junit(): write to disk', (t) => {
138138
t.plan(1);
139139
junitReporter(outputFile, passingInput);
140140
const expected = readFileSync(outputFile, 'utf8');
141-
t.equal(expected, passingExpected),
142-
'the file on disk should match the' + ' expected output';
141+
(t.equal(expected, passingExpected),
142+
'the file on disk should match the' + ' expected output');
143143
t.end();
144144
});
145145

@@ -149,8 +149,8 @@ test('reporter.junit(): append to disk', (t) => {
149149
writeFileSync(outputFileAppend, appendStartFile);
150150
junitReporter(outputFileAppend, passingInput, true);
151151
const expected = readFileSync(outputFileAppend, 'utf-8');
152-
t.equal(expected, passingExpectedAppend),
153-
'the file on disk should match the' + ' expected output';
152+
(t.equal(expected, passingExpectedAppend),
153+
'the file on disk should match the' + ' expected output');
154154
t.end();
155155
});
156156

test/reporter/test-reporter-tap.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,8 @@ test('reporter.tap(): failing', (t) => {
7979
}
8080

8181
tapReporter(logger, failingInput);
82-
t.equal(output, failingExpected),
83-
'we should get the expected output when a' + ' module fails';
82+
(t.equal(output, failingExpected),
83+
'we should get the expected output when a' + ' module fails');
8484
t.end();
8585
});
8686

@@ -96,8 +96,8 @@ test('reporter.tap(): parser', (t) => {
9696
// `results` contains JS classes that are not considered same as the
9797
// plain objects loaded from the JSON file.
9898
const plainResults = JSON.parse(JSON.stringify(results));
99-
t.same(plainResults, tapParserExpected),
100-
'the tap parser should correctly' + ' parse the tap file';
99+
(t.same(plainResults, tapParserExpected),
100+
'the tap parser should correctly' + ' parse the tap file');
101101
t.end();
102102
});
103103
str(output).pipe(p);
@@ -107,8 +107,8 @@ test('reporter.tap(): write to disk', (t) => {
107107
t.plan(1);
108108
tapReporter(outputFile, passingInput);
109109
const expected = readFileSync(outputFile, 'utf8');
110-
t.equal(expected, passingExpected),
111-
'the file on disk should match the' + ' expected output';
110+
(t.equal(expected, passingExpected),
111+
'the file on disk should match the' + ' expected output');
112112
t.end();
113113
});
114114

@@ -118,17 +118,17 @@ test('reporter.tap(): append to disk', (t) => {
118118
writeFileSync(outputFileAppend, appendStartFile);
119119
tapReporter(outputFileAppend, passingInput, true);
120120
const expected = readFileSync(outputFileAppend, 'utf8');
121-
t.equal(expected, passingExpectedAppend),
122-
'the file on disk should match the' + ' expected output';
121+
(t.equal(expected, passingExpectedAppend),
122+
'the file on disk should match the' + ' expected output');
123123
t.end();
124124
});
125125

126126
test('reporter.tap(): append to disk when file does not exist', (t) => {
127127
t.plan(1);
128128
tapReporter(outputFileAppendBlank, passingInput, true);
129129
const expected = readFileSync(outputFileAppendBlank, 'utf8');
130-
t.equal(expected, passingExpected),
131-
'the file on disk should match the' + ' expected output';
130+
(t.equal(expected, passingExpected),
131+
'the file on disk should match the' + ' expected output');
132132
t.end();
133133
});
134134

0 commit comments

Comments
 (0)