Skip to content

Commit 04acf4d

Browse files
committed
fix: use replacer fn
1 parent 7c2d74d commit 04acf4d

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

src/generators/web/template.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,6 @@
1919

2020
<body>
2121
<div id="root">{{dehydrated}}</div>
22-
23-
22+
<script>{{clientBundleJs}}</script>
23+
</body>
24+
</html>

src/generators/web/utils/processing.mjs

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -73,16 +73,11 @@ export async function processJSXEntry(
7373

7474
const title = `${entry.data.heading.data.name} | Node.js v${version} Documentation`;
7575

76-
const scriptTag = `<script>${clientBundle.js}</script>`;
77-
7876
// Replace template placeholders with actual content
79-
const filledTemplate = template
77+
const renderedHtml = template
8078
.replace('{{title}}', title)
81-
.replace('{{dehydrated}}', dehydrated ?? '');
82-
83-
const renderedHtml = `${filledTemplate}
84-
${scriptTag}
85-
</body></html>`;
79+
.replace('{{dehydrated}}', dehydrated ?? '')
80+
.replace('{{clientBundleJs}}', () => clientBundle.js);
8681

8782
// The input to `minify` must be a Buffer.
8883
const finalHTMLBuffer = HTMLMinifier.minify(Buffer.from(renderedHtml), {});

0 commit comments

Comments
 (0)