Skip to content

Commit 053ab86

Browse files
authored
fix(legacy-json): reduce diff (#524)
* fix(changes): reverse change order * fixup!
1 parent e6e3f43 commit 053ab86

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

src/generators/jsx-ast/utils/buildContent.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ export const createChangeElement = (entry, remark) => {
5858
}
5959

6060
// Sort changes by versions and reverse for newest first
61-
const sortedChanges = sortChanges(changeEntries, 'versions').reverse();
61+
const sortedChanges = sortChanges(changeEntries, 'versions');
6262

6363
return createJSXElement(JSX_IMPORTS.ChangeHistory.name, {
6464
changes: sortedChanges,

src/utils/__tests__/generators.test.mjs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,9 @@ describe('sortChanges', () => {
9090
];
9191

9292
const result = sortChanges(changes);
93-
assert.equal(result[0].version, '16.2.0');
93+
assert.equal(result[0].version, '20.1.0');
9494
assert.equal(result[1].version, '18.5.0');
95-
assert.equal(result[2].version, '20.1.0');
95+
assert.equal(result[2].version, '16.2.0');
9696
});
9797

9898
it('handles array versions', () => {
@@ -102,15 +102,15 @@ describe('sortChanges', () => {
102102
];
103103

104104
const result = sortChanges(changes);
105-
assert.equal(result[0].version[0], '16.2.0');
106-
assert.equal(result[1].version[0], '18.5.0');
105+
assert.equal(result[0].version[0], '18.5.0');
106+
assert.equal(result[1].version[0], '16.2.0');
107107
});
108108

109109
it('sorts by custom key', () => {
110110
const changes = [{ customVersion: '18.0.0' }, { customVersion: '16.0.0' }];
111111

112112
const result = sortChanges(changes, 'customVersion');
113-
assert.equal(result[0].customVersion, '16.0.0');
114-
assert.equal(result[1].customVersion, '18.0.0');
113+
assert.equal(result[0].customVersion, '18.0.0');
114+
assert.equal(result[1].customVersion, '16.0.0');
115115
});
116116
});

src/utils/generators.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,6 @@ export const sortChanges = (changes, key = 'version') => {
9393
const aVersion = Array.isArray(a[key]) ? a[key][0] : a[key];
9494
const bVersion = Array.isArray(b[key]) ? b[key][0] : b[key];
9595

96-
return compare(coerceSemVer(aVersion), coerceSemVer(bVersion));
96+
return compare(coerceSemVer(bVersion), coerceSemVer(aVersion));
9797
});
9898
};

0 commit comments

Comments
 (0)