Skip to content

Commit 0ec67fd

Browse files
committed
fix: linting
Fixes error happening with linting and also allows the cli to be ran just for linting purposes Signed-off-by: flakey5 <[email protected]>
1 parent 79cc21c commit 0ec67fd

File tree

2 files changed

+26
-24
lines changed

2 files changed

+26
-24
lines changed

bin/cli.mjs

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ program
3333
new Option(
3434
'-o, --output <path>',
3535
'Specify the relative or absolute output directory'
36-
).makeOptionMandatory()
36+
)
3737
)
3838
.addOption(
3939
new Option(
@@ -112,18 +112,20 @@ const { getAllMajors } = createNodeReleases(changelog);
112112

113113
linter.lintAll(parsedApiDocs);
114114

115-
await runGenerators({
116-
// A list of target modes for the API docs parser
117-
generators: target,
118-
// Resolved `input` to be used
119-
input: input,
120-
// Resolved `output` path to be used
121-
output: resolve(output),
122-
// Resolved SemVer of current Node.js version
123-
version: coerce(version),
124-
// A list of all Node.js major versions with LTS status
125-
releases: await getAllMajors(),
126-
});
115+
if (target && output) {
116+
await runGenerators({
117+
// A list of target modes for the API docs parser
118+
generators: target,
119+
// Resolved `input` to be used
120+
input: input,
121+
// Resolved `output` path to be used
122+
output: resolve(output),
123+
// Resolved SemVer of current Node.js version
124+
version: coerce(version),
125+
// A list of all Node.js major versions with LTS status
126+
releases: await getAllMajors(),
127+
});
128+
}
127129

128130
linter.report(reporter);
129131

src/linter/index.mjs

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,17 @@ import rules from './rules/index.mjs';
1111
* @param {string[]} disabledRules List of disabled rules names
1212
*/
1313
const createLinter = (dryRun, disabledRules) => {
14+
/**
15+
* Retrieves all enabled rules
16+
*
17+
* @returns {import('./types').LintRule[]}
18+
*/
19+
const getEnabledRules = () => {
20+
return Object.entries(rules)
21+
.filter(([ruleName]) => !disabledRules.includes(ruleName))
22+
.map(([, rule]) => rule);
23+
};
24+
1425
const engine = createLinterEngine(getEnabledRules(disabledRules));
1526

1627
/**
@@ -56,17 +67,6 @@ const createLinter = (dryRun, disabledRules) => {
5667
return issues.some(issue => issue.level === 'error');
5768
};
5869

59-
/**
60-
* Retrieves all enabled rules
61-
*
62-
* @returns {import('./types').LintRule[]}
63-
*/
64-
const getEnabledRules = () => {
65-
return Object.entries(rules)
66-
.filter(([ruleName]) => !disabledRules.includes(ruleName))
67-
.map(([, rule]) => rule);
68-
};
69-
7070
return {
7171
lintAll,
7272
report,

0 commit comments

Comments
 (0)