Apply suggestions from code review

flakey5 · avivkeller · web-flow · commit 4a44ab7f2dc6 · 2024-11-09T17:49:24.000-08:00
Co-authored-by: Aviv Keller &lt;redyetidev@gmail.com&gt;
diff --git a/src/generators/legacy-json/utils/buildSection.mjs b/src/generators/legacy-json/utils/buildSection.mjs
@@ -335,7 +335,7 @@ function handleEntry(entry, parentSection) {
     }
 
     for (const key of Object.keys(section)) {
-      if (key in ['textRaw', 'name', 'type', 'desc', 'miscs']) {
+      if (['textRaw', 'name', 'type', 'desc', 'miscs'].includes(key)) {
         continue;
       }
 

Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,7 @@ function handleEntry(entry, parentSection) {`
`335`	`335`	`}`
`336`	`336`
`337`	`337`	`for (const key of Object.keys(section)) {`
`338`		`- if (key in ['textRaw', 'name', 'type', 'desc', 'miscs']) {`
	`338`	`+ if (['textRaw', 'name', 'type', 'desc', 'miscs'].includes(key)) {`
`339`	`339`	`continue;`
`340`	`340`	`}`
`341`	`341`