code review

Signed-off-by: flakey5 <[email protected]>

Author: flakey5

src/generators/legacy-json-all/index.mjs

@@ -30,15 +30,17 @@ export default {
       methods: [],
     };
 
+    const propertiesToCopy = [
+      'miscs',
+      'modules',
+      'classes',
+      'globals',
+      'methods',
+    ];
+
     for (const section of input) {
       // Copy the relevant properties from each section into our output
-      for (const property of [
-        'miscs',
-        'modules',
-        'classes',
-        'globals',
-        'methods',
-      ]) {
+      for (const property of propertiesToCopy) {
         if (section[property]) {
           generatedValue[property].push(...section[property]);
         }

src/generators/legacy-json/utils/buildHierarchy.mjs

@@ -41,6 +41,10 @@ export function buildHierarchy(entries) {
 
       previousEntry.hierarchyChildren.push(entry);
     } else {
+      if (i < 2) {
+        throw new Error(`can't find parent since i < 2 (${i})`);
+      }
+
       // Loop to find the entry we're a child of
       for (let j = i - 2; j >= 0; j--) {
         const jEntry = entries[j];