dont clone stability, use ref

Author: avivkeller

src/generators/legacy-json/utils/buildSection.mjs

@@ -109,10 +109,11 @@ export const createSectionBuilder = () => {
       section.stability = Number(stabilityNode.data.index);
       section.stabilityText = stabilityNode.data.description;
 
-      const nodeToRemove = content.children.findIndex(
-        ({ data }) => data === stabilityNode.data
-      );
-      nodes.splice(nodeToRemove - 1, 1);
+      const stabilityIdx = content.children.indexOf(stability.children[0]);
+
+      if (stabilityIdx) {
+        nodes.splice(stabilityIdx - 1, 1);
+      }
     }
   };
 

src/metadata.mjs

@@ -47,11 +47,8 @@ const createMetadata = slugger => {
      *
      * @param {StabilityIndexParent} stability The stability index node to be added
      */
-    addStability: stability => {
-      // We clone the stability to ensure that we don't accidentally override it
-      // with later mutations below on the `.create` method
-      internalMetadata.stability.children.push({ ...stability });
-    },
+    addStability: stability =>
+      internalMetadata.stability.children.push(stability),
     /**
      * Set the Metadata (from YAML if exists) properties to the current Metadata entry
      * it also allows for extra data (such as Stability Index) and miscellaneous data to be set

src/utils/queries/index.mjs

@@ -1,6 +1,5 @@
 'use strict';
 
-import { u as createTree } from 'unist-builder';
 import { SKIP } from 'unist-util-visit';
 
 import { DOC_API_STABILITY_SECTION_REF_URL } from './constants.mjs';
@@ -142,15 +141,8 @@ const createQueries = typeMap => {
         description: matches[2].replace(/\n/g, ' ').trim(),
       };
 
-      // Creates a new Tree node containing the Stability Index metadata
-      const stabilityIndexNode = createTree(
-        'root',
-        { data: node.data },
-        node.children
-      );
-
       // Adds the Stability Index metadata to the current Metadata entry
-      apiEntryMetadata?.addStability(stabilityIndexNode);
+      apiEntryMetadata?.addStability(node);
     }
 
     return [SKIP];