Skip to content

Commit 768bfdc

Browse files
committed
chore: code review
1 parent 63fc86e commit 768bfdc

File tree

3 files changed

+45
-37
lines changed

3 files changed

+45
-37
lines changed

npm-shrinkwrap.json

Lines changed: 28 additions & 28 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/generators/legacy-json/types.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export interface SectionBase {
7878
/**
7979
* Stability index of the section.
8080
*/
81-
stability?: string;
81+
stability?: number;
8282

8383
/**
8484
* Descriptive text related to the stability of the section (E.G. "Experimental").

src/generators/legacy-json/utils/buildSection.mjs

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -47,20 +47,28 @@ export const createSectionBuilder = () => {
4747
}) => {
4848
const meta = { changes };
4949

50-
if (enforceArray(added_in).length) {
51-
meta.added = enforceArray(added_in);
50+
const aded_in_array = enforceArray(added_in);
51+
52+
if (aded_in_array.length) {
53+
meta.added = aded_in_array;
5254
}
5355

54-
if (enforceArray(n_api_version).length) {
55-
meta.napiVersion = enforceArray(n_api_version);
56+
const n_api_version_array = enforceArray(n_api_version);
57+
58+
if (n_api_version_array.length) {
59+
meta.napiVersion = n_api_version_array;
5660
}
5761

58-
if (enforceArray(deprecated_in).length) {
59-
meta.deprecated = enforceArray(deprecated_in);
62+
const deprecated_in_array = enforceArray(deprecated_in);
63+
64+
if (deprecated_in_array.length) {
65+
meta.deprecated = deprecated_in_array;
6066
}
6167

62-
if (enforceArray(removed_in).length) {
63-
meta.removed = enforceArray(removed_in);
68+
const removed_in_array = enforceArray(removed_in);
69+
70+
if (removed_in_array.length) {
71+
meta.removed = removed_in_array;
6472
}
6573

6674
// Check if there are any non-empty fields in the meta object

0 commit comments

Comments
 (0)