[wip]

Author: avivkeller

.github/workflows/compare-builds.yml

@@ -34,10 +34,10 @@ jobs:
           COMPARATORS=$(ls scripts/compare-builds/*.mjs | xargs -n1 basename | sed 's/\.mjs$//' | jq -R -s -c 'split("\n")[:-1]')
           echo "comparators=$COMPARATORS" >> $GITHUB_OUTPUT
 
-  web:
+  compare:
     name: Run ${{ matrix.comparator }} comparator
     runs-on: ubuntu-latest
-    needs: [get-comparators]
+    needs: get-comparators
     strategy:
       matrix:
         comparator: ${{ fromJSON(needs.get-comparators.outputs.comparators) }}
@@ -82,18 +82,23 @@ jobs:
         id: compare
         run: |
           node scripts/compare-builds/${{ matrix.comparator }}.mjs > result.txt
+          if [ -s result.txt ]; then
+            echo "has_output=true" >> "$GITHUB_OUTPUT"
+          else
+            echo "has_output=false" >> "$GITHUB_OUTPUT"
+          fi
 
       - name: Upload comparison artifact
+        if: steps.compare.outputs.has_output == 'true'
         uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
         with:
           name: ${{ matrix.comparator }}
-          path: result.txt
+          path: ${{ matrix.comparator }}.txt
 
   aggregate:
     name: Aggregate Comparison Results
     runs-on: ubuntu-latest
-    needs: [web]
-
+    needs: compare
     steps:
       - name: Download all comparison artifacts
         uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
@@ -103,17 +108,25 @@ jobs:
       - name: Combine results
         id: combine
         run: |
-          tree .
-          cat results/**/*.txt > combined.txt
-          echo "combined<<EOF" >> $GITHUB_OUTPUT
-          cat combined.txt >> $GITHUB_OUTPUT
-          echo "EOF" >> $GITHUB_OUTPUT
+          result_files=(results/*.txt)
+
+          if (( ${#result_files[@]} )); then
+            cat "${result_files[@]}" > combined.txt
+            {
+              echo "combined<<EOF"
+              cat combined.txt
+              echo "EOF"
+              echo "has_results=true"
+            } >> "$GITHUB_OUTPUT"
+          else
+            echo "has_results=false" >> "$GITHUB_OUTPUT"
+          fi
 
-      - run: echo combined.txt
       - name: Add Comment to PR
+        if: steps.combine.outputs.has_results == 'true'
         uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
         with:
-          comment-tag: 'compared'
+          comment-tag: compared
           message: ${{ steps.combine.outputs.combined }}
           pr-number: ${{ github.event.pull_request.number }}
           # pr-number: ${{ github.event.workflow_run.pull_requests[0].number }}