chore: more self review

Author: ovflowd

src/generators/ast-js/index.mjs

@@ -1,3 +1,7 @@
+import { extname } from 'node:path';
+
+import { globSync } from 'glob';
+
 import createJsLoader from '../../loaders/javascript.mjs';
 import createJsParser from '../../parsers/javascript.mjs';
 
@@ -49,10 +53,10 @@ export default {
    * @param {Input} _
    * @param {Partial<GeneratorOptions>} options
    */
-  async generate(_, { input, worker }) {
-    // Load all of the Javascript sources into memory
-    const sourceFiles =
-      input?.filter(filename => filename.endsWith('.js')) ?? [];
+  async generate(_, { input = [], worker }) {
+    const sourceFiles = globSync(input).filter(
+      filePath => extname(filePath) === '.js'
+    );
 
     // Parse the Javascript sources into ASTs in parallel using worker threads
     return worker.map(sourceFiles, _, { input: sourceFiles });

src/generators/jsx-ast/index.mjs

@@ -4,44 +4,52 @@ import buildContent from './utils/buildContent.mjs';
 import { groupNodesByModule } from '../../utils/generators.mjs';
 import { getRemarkRecma } from '../../utils/remark.mjs';
 
-/**
- * Generator for converting MDAST to JSX AST.
- *
- * @typedef {Array<ApiDocMetadataEntry>} Input
- * @type {GeneratorMetadata<Input, string>}
- */
-
 /**
  * Sorts entries by OVERRIDDEN_POSITIONS and then heading name.
  * @param {Array<ApiDocMetadataEntry>} entries
  */
 const getSortedHeadNodes = entries => {
-  return entries
-    .filter(node => node.heading.depth === 1)
-    .sort((a, b) => {
-      const ai = OVERRIDDEN_POSITIONS.indexOf(a.api);
-      const bi = OVERRIDDEN_POSITIONS.indexOf(b.api);
-
-      if (ai !== -1 && bi !== -1) {
-        return ai - bi;
-      }
-
-      if (ai !== -1) {
-        return -1;
-      }
-
-      if (bi !== -1) {
-        return 1;
-      }
-
-      return a.heading.data.name.localeCompare(b.heading.data.name);
-    });
+  /**
+   * Sorts entries by OVERRIDDEN_POSITIONS and then heading name.
+   * @param {ApiDocMetadataEntry} a
+   * @param {ApiDocMetadataEntry} b
+   * @returns {number}
+   */
+  const headingSortFn = (a, b) => {
+    const ai = OVERRIDDEN_POSITIONS.indexOf(a.api);
+    const bi = OVERRIDDEN_POSITIONS.indexOf(b.api);
+
+    if (ai !== -1 && bi !== -1) {
+      return ai - bi;
+    }
+
+    if (ai !== -1) {
+      return -1;
+    }
+
+    if (bi !== -1) {
+      return 1;
+    }
+
+    return a.heading.data.name.localeCompare(b.heading.data.name);
+  };
+
+  return entries.filter(node => node.heading.depth === 1).sort(headingSortFn);
 };
 
+/**
+ * Generator for converting MDAST to JSX AST.
+ *
+ * @typedef {Array<ApiDocMetadataEntry>} Input
+ * @type {GeneratorMetadata<Input, string>}
+ */
 export default {
   name: 'jsx-ast',
+
   version: '1.0.0',
+
   description: 'Generates JSX AST from the input MDAST',
+
   dependsOn: 'metadata',
 
   /**
@@ -71,14 +79,14 @@ export default {
         docPages
       );
 
-      results.push(
-        await buildContent(
-          groupedModules.get(entry.api),
-          entry,
-          sideBarProps,
-          remarkRecma
-        )
+      const content = await buildContent(
+        groupedModules.get(entry.api),
+        entry,
+        sideBarProps,
+        remarkRecma
       );
+
+      results.push(content);
     }
 
     return results;
@@ -92,7 +100,7 @@ export default {
    * @returns {Promise<Array<string>>} Array of generated content
    */
   async generate(entries, { index, releases, version, worker }) {
-    const headNodes = getSortedHeadNodes(entries);
+    const headNodes = entries.filter(node => node.heading.depth === 1);
 
     return worker.map(headNodes, entries, { index, releases, version });
   },

src/threading/chunk-worker.mjs

@@ -3,6 +3,7 @@ import { parentPort, workerData } from 'node:worker_threads';
 import { allGenerators } from '../generators/index.mjs';
 
 const { generatorName, fullInput, itemIndices, options } = workerData;
+
 const generator = allGenerators[generatorName];
 
 // Generators must implement processChunk for item-level parallelization