Skip to content

Commit fba5ee2

Browse files
committed
don't assumev in NODE_RELEASED_VERSIONS
1 parent 246cc34 commit fba5ee2

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/linter/rules/invalid-change-version.mjs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ const NODE_RELEASED_VERSIONS = env.NODE_RELEASED_VERSIONS?.split(',');
1212
*/
1313
const isInvalid = NODE_RELEASED_VERSIONS
1414
? version =>
15-
version !== 'REPLACEME' && !NODE_RELEASED_VERSIONS.includes(version)
15+
version !== 'REPLACEME' &&
16+
!NODE_RELEASED_VERSIONS.includes(version.replace(/^v/, ''))
1617
: version => version !== 'REPLACEME' && !valid(version);
1718

1819
/**

src/linter/tests/rules/invalid-change-version.test.mjs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ describe('invalidChangeVersion', () => {
2121
{
2222
env: {
2323
NODE_RELEASED_VERSIONS: [
24-
'v9.9.0',
25-
'v13.9.0',
26-
'v12.16.2',
27-
'v15.0.0',
24+
'9.9.0',
25+
'13.9.0',
26+
'12.16.2',
27+
'15.0.0',
2828
'REPLACEME',
2929
'SOME_OTHER_RELEASED_VERSION',
3030
].join(','),

0 commit comments

Comments
 (0)