Skip to content

Commit 1c65c4e

Browse files
author
Christopher Horrell
committed
Set ENV for NODE_ENV
This ensures that the value of NODE_ENV is made available to the CMD context. This ensures commands such as `npm start` or `node index.js` are using the correct NODE_ENV. See comments in docker-library/official-images#2156
1 parent bfad769 commit 1c65c4e

File tree

5 files changed

+5
-0
lines changed

5 files changed

+5
-0
lines changed

0.10/onbuild/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ RUN mkdir -p /usr/src/app
44
WORKDIR /usr/src/app
55

66
ONBUILD ARG NODE_ENV
7+
ONBUILD ENV NODE_ENV $NODE_ENV
78
ONBUILD COPY package.json /usr/src/app/
89
ONBUILD RUN npm install
910
ONBUILD COPY . /usr/src/app

0.12/onbuild/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ RUN mkdir -p /usr/src/app
44
WORKDIR /usr/src/app
55

66
ONBUILD ARG NODE_ENV
7+
ONBUILD ENV NODE_ENV $NODE_ENV
78
ONBUILD COPY package.json /usr/src/app/
89
ONBUILD RUN npm install
910
ONBUILD COPY . /usr/src/app

4.5/onbuild/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ RUN mkdir -p /usr/src/app
44
WORKDIR /usr/src/app
55

66
ONBUILD ARG NODE_ENV
7+
ONBUILD ENV NODE_ENV $NODE_ENV
78
ONBUILD COPY package.json /usr/src/app/
89
ONBUILD RUN npm install
910
ONBUILD COPY . /usr/src/app

6.6/onbuild/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ RUN mkdir -p /usr/src/app
44
WORKDIR /usr/src/app
55

66
ONBUILD ARG NODE_ENV
7+
ONBUILD ENV NODE_ENV $NODE_ENV
78
ONBUILD COPY package.json /usr/src/app/
89
ONBUILD RUN npm install
910
ONBUILD COPY . /usr/src/app

Dockerfile-onbuild.template

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ RUN mkdir -p /usr/src/app
44
WORKDIR /usr/src/app
55

66
ONBUILD ARG NODE_ENV
7+
ONBUILD ENV NODE_ENV $NODE_ENV
78
ONBUILD COPY package.json /usr/src/app/
89
ONBUILD RUN npm install
910
ONBUILD COPY . /usr/src/app

0 commit comments

Comments
 (0)