Skip to content

Commit 679bd8f

Browse files
authored
Merge pull request #1606 from nodejs/nschonni-patch-1
2 parents 8fc91b3 + 8a750d6 commit 679bd8f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

docs/BestPractices.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ Here is an example of how you would install dependencies for packages that requi
185185
```Dockerfile
186186
FROM node:alpine
187187

188-
RUN apk add --no-cache --virtual .gyp python make g++ \
188+
RUN apk add --no-cache --virtual .gyp python3 make g++ \
189189
&& npm install [ your npm dependencies here ] \
190190
&& apk del .gyp
191191
```
@@ -196,7 +196,7 @@ And Here's a multistage build example
196196
FROM node:alpine as builder
197197

198198
## Install build toolchain, install node deps and compile native add-ons
199-
RUN apk add --no-cache python make g++
199+
RUN apk add --no-cache python3 make g++
200200
RUN npm install [ your npm dependencies here ]
201201

202202
FROM node:alpine as app

0 commit comments

Comments
 (0)