Skip to content

Commit 712ead7

Browse files
Refactor to make test-build.sh shorter
1 parent 8cbad29 commit 712ead7

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

test-build.sh

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,16 +34,14 @@ for version in "${versions[@]}"; do
3434

3535
if ! docker build -t node:"$tag" "$version"; then
3636
fatal "Build of $tag failed!"
37-
else
38-
info "Build of $tag succeeded."
3937
fi
38+
info "Build of $tag succeeded."
4039

4140
OUTPUT=$(docker run --rm -it node:"$tag" node -e "process.stdout.write(process.versions.node)")
4241
if [ "$OUTPUT" != "$tag" ]; then
4342
fatal "Test of $tag failed!"
44-
else
45-
info "Test of $tag succeeded."
4643
fi
44+
info "Test of $tag succeeded."
4745

4846
variants=$(echo "$version"/*/ | xargs -n1 basename)
4947

@@ -55,16 +53,14 @@ for version in "${versions[@]}"; do
5553

5654
if ! docker build -t node:"$tag-$variant" "$version/$variant"; then
5755
fatal "Build of $tag-$variant failed!"
58-
else
59-
info "Build of $tag-$variant succeeded."
6056
fi
57+
info "Build of $tag-$variant succeeded."
6158

6259
OUTPUT=$(docker run --rm -it node:"$tag-$variant" node -e "process.stdout.write(process.versions.node)")
6360
if [ "$OUTPUT" != "$tag" ]; then
6461
fatal "Test of $tag-$variant failed!"
65-
else
66-
info "Test of $tag-$variant succeeded."
6762
fi
63+
info "Test of $tag-$variant succeeded."
6864

6965
done
7066

0 commit comments

Comments
 (0)