Merge pull request #1634 from PeterDaveHello/improve-update-script

nschonni · web-flow · commit c357b987ae71 · 2022-02-01T09:44:50.000-05:00
Clean up temp Dockerfile in update.sh before fatal exit
diff --git a/update.sh b/update.sh
@@ -160,6 +160,7 @@ function update_node_version() {
         curl -sSL --compressed "https://unofficial-builds.nodejs.org/download/release/v${nodeVersion}/SHASUMS256.txt" | grep "node-v${nodeVersion}-linux-x64-musl.tar.xz" | cut -d' ' -f1
       )
       if [ -z "$checksum" ]; then
+        rm -f "${dockerfile}-tmp"
         fatal "Failed to fetch checksum for version ${nodeVersion}"
       fi
       sed -Ei -e "s/(alpine:)0.0/\\1${alpine_version}/" "${dockerfile}-tmp"

Original file line number	Diff line number	Diff line change
`@@ -160,6 +160,7 @@ function update_node_version() {`
`160`	`160`	`curl -sSL --compressed "https://unofficial-builds.nodejs.org/download/release/v${nodeVersion}/SHASUMS256.txt" \| grep "node-v${nodeVersion}-linux-x64-musl.tar.xz" \| cut -d' ' -f1`
`161`	`161`	`)`
`162`	`162`	`if [ -z "$checksum" ]; then`
	`163`	`+ rm -f "${dockerfile}-tmp"`
`163`	`164`	`fatal "Failed to fetch checksum for version ${nodeVersion}"`
`164`	`165`	`fi`
`165`	`166`	`sed -Ei -e "s/(alpine:)0.0/\\1${alpine_version}/" "${dockerfile}-tmp"`