Skip to content

Commit cbb4a22

Browse files
chorrellchorrell
committed
Merge pull request #167 from nodejs/revert-162-env-var-top
Revert "Moved the environment variables to the top of the Dockerfile"
2 parents 353e7d5 + b3367b8 commit cbb4a22

File tree

15 files changed

+39
-39
lines changed

15 files changed

+39
-39
lines changed

‎0.10/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
FROM buildpack-deps:jessie
22

3-
ENV NODE_VERSION 0.10.44
4-
53
# gpg keys listed at https://github.com/nodejs/node
64
RUN set -ex \
75
&& for key in \
@@ -17,6 +15,8 @@ RUN set -ex \
1715
gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \
1816
done
1917

18+
ENV NODE_VERSION 0.10.44
19+
2020
RUN curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.xz" \
2121
&& curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/SHASUMS256.txt.asc" \
2222
&& gpg --batch --decrypt --output SHASUMS256.txt SHASUMS256.txt.asc \

‎0.10/slim/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
FROM buildpack-deps:jessie-curl
22

3-
ENV NODE_VERSION 0.10.44
4-
53
# gpg keys listed at https://github.com/nodejs/node
64
RUN set -ex \
75
&& for key in \
@@ -17,6 +15,8 @@ RUN set -ex \
1715
gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \
1816
done
1917

18+
ENV NODE_VERSION 0.10.44
19+
2020
RUN buildDeps='xz-utils' \
2121
&& set -x \
2222
&& apt-get update && apt-get install -y $buildDeps --no-install-recommends \

‎0.10/wheezy/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
FROM buildpack-deps:wheezy
22

3-
ENV NODE_VERSION 0.10.44
4-
53
# gpg keys listed at https://github.com/nodejs/node
64
RUN set -ex \
75
&& for key in \
@@ -17,6 +15,8 @@ RUN set -ex \
1715
gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \
1816
done
1917

18+
ENV NODE_VERSION 0.10.44
19+
2020
RUN curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.xz" \
2121
&& curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/SHASUMS256.txt.asc" \
2222
&& gpg --batch --decrypt --output SHASUMS256.txt SHASUMS256.txt.asc \

‎0.12/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
FROM buildpack-deps:jessie
22

3-
ENV NODE_VERSION 0.12.13
4-
53
# gpg keys listed at https://github.com/nodejs/node
64
RUN set -ex \
75
&& for key in \
@@ -17,6 +15,8 @@ RUN set -ex \
1715
gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \
1816
done
1917

18+
ENV NODE_VERSION 0.12.13
19+
2020
RUN curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.xz" \
2121
&& curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/SHASUMS256.txt.asc" \
2222
&& gpg --batch --decrypt --output SHASUMS256.txt SHASUMS256.txt.asc \

‎0.12/slim/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
FROM buildpack-deps:jessie-curl
22

3-
ENV NODE_VERSION 0.12.13
4-
53
# gpg keys listed at https://github.com/nodejs/node
64
RUN set -ex \
75
&& for key in \
@@ -17,6 +15,8 @@ RUN set -ex \
1715
gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \
1816
done
1917

18+
ENV NODE_VERSION 0.12.13
19+
2020
RUN buildDeps='xz-utils' \
2121
&& set -x \
2222
&& apt-get update && apt-get install -y $buildDeps --no-install-recommends \

‎0.12/wheezy/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
FROM buildpack-deps:wheezy
22

3-
ENV NODE_VERSION 0.12.13
4-
53
# gpg keys listed at https://github.com/nodejs/node
64
RUN set -ex \
75
&& for key in \
@@ -17,6 +15,8 @@ RUN set -ex \
1715
gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \
1816
done
1917

18+
ENV NODE_VERSION 0.12.13
19+
2020
RUN curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.xz" \
2121
&& curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/SHASUMS256.txt.asc" \
2222
&& gpg --batch --decrypt --output SHASUMS256.txt SHASUMS256.txt.asc \

‎4.4/Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
FROM buildpack-deps:jessie
22

3-
ENV NPM_CONFIG_LOGLEVEL info
4-
ENV NODE_VERSION 4.4.3
5-
63
# gpg keys listed at https://github.com/nodejs/node
74
RUN set -ex \
85
&& for key in \
@@ -18,6 +15,9 @@ RUN set -ex \
1815
gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \
1916
done
2017

18+
ENV NPM_CONFIG_LOGLEVEL info
19+
ENV NODE_VERSION 4.4.3
20+
2121
RUN curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.xz" \
2222
&& curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/SHASUMS256.txt.asc" \
2323
&& gpg --batch --decrypt --output SHASUMS256.txt SHASUMS256.txt.asc \

‎4.4/slim/Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
FROM buildpack-deps:jessie-curl
22

3-
ENV NPM_CONFIG_LOGLEVEL info
4-
ENV NODE_VERSION 4.4.3
5-
63
# gpg keys listed at https://github.com/nodejs/node
74
RUN set -ex \
85
&& for key in \
@@ -18,6 +15,9 @@ RUN set -ex \
1815
gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \
1916
done
2017

18+
ENV NPM_CONFIG_LOGLEVEL info
19+
ENV NODE_VERSION 4.4.3
20+
2121
RUN buildDeps='xz-utils' \
2222
&& set -x \
2323
&& apt-get update && apt-get install -y $buildDeps --no-install-recommends \

‎4.4/wheezy/Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
FROM buildpack-deps:wheezy
22

3-
ENV NPM_CONFIG_LOGLEVEL info
4-
ENV NODE_VERSION 4.4.3
5-
63
# gpg keys listed at https://github.com/nodejs/node
74
RUN set -ex \
85
&& for key in \
@@ -18,6 +15,9 @@ RUN set -ex \
1815
gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \
1916
done
2017

18+
ENV NPM_CONFIG_LOGLEVEL info
19+
ENV NODE_VERSION 4.4.3
20+
2121
RUN curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.xz" \
2222
&& curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/SHASUMS256.txt.asc" \
2323
&& gpg --batch --decrypt --output SHASUMS256.txt SHASUMS256.txt.asc \

‎5.11/Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
FROM buildpack-deps:jessie
22

3-
ENV NPM_CONFIG_LOGLEVEL info
4-
ENV NODE_VERSION 5.11.0
5-
63
# gpg keys listed at https://github.com/nodejs/node
74
RUN set -ex \
85
&& for key in \
@@ -18,6 +15,9 @@ RUN set -ex \
1815
gpg --keyserver ha.pool.sks-keyservers.net --recv-keys "$key"; \
1916
done
2017

18+
ENV NPM_CONFIG_LOGLEVEL info
19+
ENV NODE_VERSION 5.11.0
20+
2121
RUN curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.xz" \
2222
&& curl -SLO "https://nodejs.org/dist/v$NODE_VERSION/SHASUMS256.txt.asc" \
2323
&& gpg --batch --decrypt --output SHASUMS256.txt SHASUMS256.txt.asc \

0 commit comments

Comments
 (0)