fix: do not replace dollar sign in shim variable name (#200)

cjpearson · web-flow · commit 20bf0e5c5f6f · 2025-06-13T16:29:36.000+02:00
diff --git a/hook.js b/hook.js
@@ -254,7 +254,7 @@ async function processModule ({ srcUrl, context, parentGetSource, parentResolve,
         addSetter(name, setter, true)
       }
     } else {
-      const variableName = `$${n.replace(/[^a-zA-Z0-9_]/g, '_')}`
+      const variableName = `$${n.replace(/[^a-zA-Z0-9_$]/g, '_')}`
       const objectKey = JSON.stringify(n)
       const reExportedName = n === 'default' || NODE_MAJOR < 16 ? n : objectKey
 
diff --git a/test/fixtures/invalid-identifier.js b/test/fixtures/invalid-identifier.js
@@ -3,3 +3,6 @@ exports['one.two'] = () => console.log('b')
 
 // See: https://github.com/nodejs/import-in-the-middle/issues/94
 exports['unsigned short'] = 'something'
+
+exports._ = 'foo'
+exports.$ = 'bar'

Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,7 @@ async function processModule ({ srcUrl, context, parentGetSource, parentResolve,`
`254`	`254`	`addSetter(name, setter, true)`
`255`	`255`	`}`
`256`	`256`	`} else {`
`257`		- const variableName = `$${n.replace(/[^a-zA-Z0-9_]/g, '_')}`
	`257`	+ const variableName = `$${n.replace(/[^a-zA-Z0-9_$]/g, '_')}`
`258`	`258`	`const objectKey = JSON.stringify(n)`
`259`	`259`	`const reExportedName = n === 'default' \|\| NODE_MAJOR < 16 ? n : objectKey`
`260`	`260`