src: fix inspection of read-only properties

Read-onlyness shouldn't influnece from where we read the property data.

Fixes: #209

PR-URL: #221
Fixes: #198
Refs: #209
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>

Author: Matheus Marchini

src/llv8-inl.h

@@ -510,10 +510,7 @@ inline bool DescriptorArray::IsConstFieldDetails(Smi details) {
   }
 
   // node.js >= 8
-  return (details.GetValue() &
-          v8()->descriptor_array()->kPropertyAttributesMask) ==
-         (v8()->descriptor_array()->kPropertyAttributesEnum_READ_ONLY
-          << v8()->descriptor_array()->kPropertyAttributesShift);
+  return false;
 }
 
 inline bool DescriptorArray::IsDoubleField(Smi details) {

src/llv8.cc

@@ -10,9 +10,9 @@
 namespace llnode {
 namespace v8 {
 
-using lldb::addr_t;
 using lldb::SBError;
 using lldb::SBTarget;
+using lldb::addr_t;
 
 static std::string kConstantPrefix = "v8dbg_";
 
@@ -1516,7 +1516,8 @@ std::string JSObject::InspectDescriptors(Map map, Error& err) {
     res += "    ." + key.ToString(err) + "=";
     if (err.Fail()) return std::string();
 
-    if (descriptors.IsConstFieldDetails(details) || descriptors.IsDescriptorDetails(details)) {
+    if (descriptors.IsConstFieldDetails(details) ||
+        descriptors.IsDescriptorDetails(details)) {
       Value value;
 
       value = descriptors.GetValue(i, err);
@@ -1665,7 +1666,8 @@ std::vector<std::pair<Value, Value>> JSObject::DescriptorEntries(Map map,
     Value key = descriptors.GetKey(i, err);
     if (err.Fail()) continue;
 
-    if (descriptors.IsConstFieldDetails(details)) {
+    if (descriptors.IsConstFieldDetails(details) ||
+        descriptors.IsDescriptorDetails(details)) {
       Value value;
 
       value = descriptors.GetValue(i, err);
@@ -1871,7 +1873,8 @@ Value JSObject::GetDescriptorProperty(std::string key_name, Map map,
     // Found the right key, get the value.
     if (err.Fail()) return Value();
 
-    if (descriptors.IsConstFieldDetails(details)) {
+    if (descriptors.IsConstFieldDetails(details) ||
+        descriptors.IsDescriptorDetails(details)) {
       Value value;
 
       value = descriptors.GetValue(i, err);