Skip to content

Commit a1f46d8

Browse files
Merge pull request #18 from nodejs/2021-07-09-minutes
2021-07-09 minutes
2 parents 29e28bb + d7adb7d commit a1f46d8

File tree

1 file changed

+24
-0
lines changed

1 file changed

+24
-0
lines changed

doc/meetings/2021-07-09.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# Node.js Loaders Team Meeting 2021-07-09
2+
3+
## Links
4+
5+
* **Recording**: https://www.youtube.com/watch?v=qB5owXywsVw
6+
* **GitHub Issue**: https://github.com/nodejs/loaders/issues/17
7+
8+
## Present
9+
10+
* Loaders team: @nodejs/loaders
11+
* Geoffrey Booth: @GeoffreyBooth
12+
* Michael Dawson: @mhdawson
13+
* Jacob Smith: @JakobJingleheimer
14+
* Bradley Meck: @bmeck
15+
16+
## Agenda
17+
18+
### nodejs/node
19+
20+
* esm: consolidate ESM Loader methods [#37468](https://github.com/nodejs/node/pull/37468)
21+
22+
Jacob’s PR is nearing completion. Geoffrey had suggested previously that Jacob get the CoffeeScript and HTTPS examples in https://github.com/GeoffreyBooth/node-loaders working against the build of Node from Jacob’s PR’s branch. (That repo contains runnable versions of the examples in the ESM loaders docs.) Jacob has been working on it and ran into an issue: https://github.com/GeoffreyBooth/node-loaders/pull/2 where a hacky way of determining module type in the example CoffeeScript loader was no longer possible with the merging of the `getFormat` and `load` hooks. We discussed alternatives such as the `resolvePackageRoot` API that’s been under consideration (https://github.com/nodejs/modules/issues/516) but eventually agreed to just implement our own “walk up the file system to find the nearest `package.json` file” logic so as not to be dependent/blocked on other efforts. Jacob will do that and hopefully then his PR can be ready for final code review.
23+
24+
We also discussed moving https://github.com/GeoffreyBooth/node-loaders to an official location like https://github.com/nodejs/loaders-examples. Geoffrey will add some READMEs to that repo and move the non-working loaders into a subfolder like “works-in-progress”, and talk to the nodejs admins about moving the repo into the nodejs org. This would follow the precedent of the https://github.com/nodejs/node-addon-examples repo.

0 commit comments

Comments
 (0)