Skip to content

Commit aa13ec9

Browse files
2021-10-12 notes (#42)
Co-authored-by: Jacob Smith <[email protected]>
1 parent 8cd4be3 commit aa13ec9

File tree

1 file changed

+22
-0
lines changed

1 file changed

+22
-0
lines changed

doc/meetings/2021-10-12.md

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# Node.js Loaders Team Meeting 2021-10-12
2+
3+
## Links
4+
5+
* **Recording**: https://www.youtube.com/watch?v=hxaFpjKy84E
6+
* **GitHub Issue**: https://github.com/nodejs/loaders/issues/40
7+
8+
## Present
9+
10+
* Geoffrey Booth: @GeoffreyBooth
11+
* Antoine du Hamel: @aduh95
12+
* Jacob Smith: @JakobJingleheimer
13+
* Myles Borins: @MylesBorins
14+
* Bradley Farias: @bmeck
15+
16+
## Agenda
17+
18+
* module: unflag import assertions [#40250](https://github.com/nodejs/node/pull/40250)
19+
20+
## Notes
21+
22+
Discussion over whether assertion should be part of the module cache key or not, and consequences of one way or the other. @GeoffreyBooth will try to implement an approach where the assertions are part of the module _job,_ and checking the assertions will happen at the same time as the URL (key) is compared, effectively making it a combined key while still having one job per key. Open question of what to do when a mismatch is found. Will investigate in the open PR, and can even land with a tentative solution that can change later since JSON modules are still flagged and this is an edge case that should never happen in realistic code (two import statements resolving to the same URL, with different assertions).

0 commit comments

Comments
 (0)