Renames into readFile / statFile

Author: arcanis

doc/design/overview.md

@@ -1,19 +1,21 @@
 # Loaders Design
 
-There are currently [three loader hooks](https://github.com/nodejs/node/tree/master/doc/api/esm.html#esm_hooks):
+There are currently the following [loader hooks](https://github.com/nodejs/node/tree/master/doc/api/esm.html#esm_hooks):
 
 1. `resolve`: Takes a specifier (the string after `from` in an `import` statement) and converts it into an URL to be loaded.
 
-1. `loadManifest`: Takes the resolved URL and returns the `package.json` from the location (or `null` if it doesn't exist).
-
 1. `load`: Takes the resolved URL and returns runnable code (JavaScript, Wasm, etc.) as well as the name of one of Node’s ESM loader’s [“translators”](https://github.com/nodejs/node/blob/master/lib/internal/modules/esm/translators.js):
    * `commonjs`
    * `module`
    * `builtin` (a Node internal module, like `fs`)
    * `json` (with `--experimental-json-modules`)
    * `wasm` (with `--experimental-wasm-modules`)
 
-* `globalPreload`: Defines a string of JavaScript to be injected into the application global scope.
+1. `statFile`: Takes the resolved URL and returns its [`fs.Stats` record](https://nodejs.org/api/fs.html#class-fsstats) (or `null` if it doesn't exist).
+
+1. `readFile`: Takes the resolved URL and returns its binary content (or `null` if it doesn't exist).
+
+1. `globalPreload`: Defines a string of JavaScript to be injected into the application global scope.
 
 ## Chaining
 

doc/design/proposal-chaining-iterative.md

@@ -283,7 +283,7 @@ const babelOutputToFormat = new Map([
 ```
 </details>
 
-## Chaining `loadManifest` hooks
+## Chaining `readFile` hooks
 
 Say you had a chain of three loaders:
 
@@ -302,26 +302,24 @@ node \
 
 These would be called in the following sequence:
 
-(`zip` OR `defaultLoadManifest`) → `tgz` → `warc`
+(`zip` OR `defaultReadFile`) → `tgz` → `warc`
 
-1. `defaultLoadManifest` / `zip` needs to be first to know whether the manifest exists on the actual filesystem, which is fed to the subsequent loader
+1. `defaultReadFile` / `zip` needs to be first to know whether the manifest exists on the actual filesystem, which is fed to the subsequent loader
 1. `tgz` receives the raw source from the previous loader and, if necessary, checks for the manifest existence via its own rules
 1. `warc` does the same thing
 
 LoadManifest hooks would have the following signature:
 
 ```ts
-export async function loadManifest(
-  manifestUrl: string,         // A URL that may or may not point to an existing
-                               // location
+export async function readFile(
+  url: string,                // A URL that point to a location; whether the file
+                               // exists or not isn't guaranteed
   interimResult: {             // result from the previous hook
-    manifest: string | ArrayBuffer | TypedArray | null, // The content of the
-                               // manifest, or `null` if it doesn't exist.
+    data: string | ArrayBuffer | TypedArray | null, // The content of the
+                               // file, or `null` if it doesn't exist.
   },
   context: {
     conditions = string[],     // Export conditions of the relevant package.json
-    parentUrl = null,          // The module importing this one, or null if
-                               // this is the Node entry point
   },
   defaultLoadManifest: function, // Node's default load hook
 ): {
@@ -330,7 +328,7 @@ export async function loadManifest(
     interimIgnored?: true,     // interimResult was intentionally ignored
     shortCircuit?: true,       // `resolve` chain should be terminated
   },
-  manifest: string | ArrayBuffer | TypedArray | null, // The content of the
-                             // manifest, or `null` if it doesn't exist.
+  data: string | ArrayBuffer | TypedArray | null, // The content of the
+                               // file, or `null` if it doesn't exist.
 } {
 ```

doc/design/proposal-chaining-middleware.md

@@ -264,7 +264,7 @@ export async function load(
 ```
 </details>
 
-## Chaining `loadManifest` hooks
+## Chaining `readFile` hooks
 
 Say you had a chain of three loaders:
 
@@ -286,20 +286,18 @@ These would be called in the following sequence: `zip` calls `tgz`, which calls
 Load hooks would have the following signature:
 
 ```ts
-export async function loadManifest(
-  manifestUrl: string,       // A URL that may or may not point to an existing
-                             // location
+export async function readFile(
+  url: string,               // A URL that point to a location; whether the file
+                             // exists or not isn't guaranteed
   context: {
     conditions = string[],   // Export conditions of the relevant `package.json`
-    parentUrl = null,        // The module importing this one, or null if
-                             // this is the Node entry point
   },
-  next: function,            // The subsequent `loadManifest` hook in the chain,
-                             // or Node’s default `loadManifest` hook after the
-                             // last user-supplied `loadManifest` hook
+  next: function,            // The subsequent `readFile` hook in the chain,
+                             // or Node’s default `readFile` hook after the
+                             // last user-supplied `readFile` hook
 ): {
-  manifest: string | ArrayBuffer | TypedArray | null, // The content of the
-                             // manifest, or `null` if it doesn't exist.
+  data: string | ArrayBuffer | TypedArray | null, // The content of the
+                             // file, or `null` if it doesn't exist.
   shortCircuit?: true,       // A signal that this hook intends to terminate
                              // the chain of `load` hooks
 } {