Skip to content

Commit de5aa44

Browse files
2022-06-21 meeting (#90)
1 parent 7f923bc commit de5aa44

File tree

1 file changed

+31
-0
lines changed

1 file changed

+31
-0
lines changed

doc/meetings/2022-06-21.md

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
# Node.js Loaders Team Meeting 2022-06-21
2+
3+
## Links
4+
5+
* **Recording**: https://www.youtube.com/watch?v=jh37GJZazz0
6+
* **GitHub Issue**: https://github.com/nodejs/loaders/issues/88
7+
8+
## Present
9+
10+
* Loaders team: @nodejs/loaders
11+
* Geoffrey Booth: @GeoffreyBooth
12+
* Guy Bedford: @guybedford
13+
* Bradley Farias: @bmeck
14+
* Jacob Smith: @JakobJingleheimer
15+
16+
## Agenda
17+
18+
* https://github.com/nodejs/loaders/pull/89: Proposal for `preImport` hook
19+
20+
## Notes
21+
22+
Moving loaders off-thread might let us preserve an async `resolve` hook, with an `import.meta.resolve` that will appear to user code to be synchronous (can be called without `await`).
23+
24+
### Plan per today:
25+
26+
* Revert [the PR that changed our loader `resolve` hook and `import.meta.resolve` to become sync](https://github.com/nodejs/node/pull/43363), with a note that the PR will go back in if we discover that we can’t keep our async `resolve` hook with sync-looking `import.meta.resolve` via moving loaders off-thread. (Or if we discover that we can’t move loaders off-thread after all.)
27+
28+
* Close the [`preImport` PR](https://github.com/nodejs/node/pull/43245) for now, as we won’t need it if we can preserve the async `resolve`.
29+
30+
* Work on moving loaders off thread. Confirm that we _can_ keep the async `resolve` hook. If we succeed, we’re done and we can move on without reviving the old sync `resolve` and `preImport` PRs.
31+

0 commit comments

Comments
 (0)