test: create HandleScope in weak callback (#887)

nornagon · web-flow · commit 2c4ee8a32a29 · 2020-03-03T15:10:28.000+02:00
test: create HandleScope in weak callbacks By analogy with https://chromium.googlesource.com/v8/v8/+/8c8bd658c6f3a765a73ac49e57b7b138a67db635/test/cctest/test-api.cc#13418
diff --git a/test/cpp/weak.cpp b/test/cpp/weak.cpp
@@ -15,6 +15,7 @@ static Persistent<v8::Function> cb;
 
 void weakCallback(
     const WeakCallbackInfo<int> &data) {  // NOLINT(runtime/references)
+  HandleScope scope;
   int *parameter = data.GetParameter();
   v8::Local<v8::Value> val = New(*parameter);
   async_resource->runInAsyncScope(
diff --git a/test/cpp/weak2.cpp b/test/cpp/weak2.cpp
@@ -14,6 +14,7 @@ static AsyncResource* async_resource;
 static Persistent<v8::Function> cb;
 void weakCallback(
     const WeakCallbackInfo<int> &data) {  // NOLINT(runtime/references)
+  HandleScope scope;
   int *parameter = static_cast<int*>(data.GetInternalField(0));
   v8::Local<v8::Value> val = New(*parameter);
   async_resource->runInAsyncScope(
