Skip to content

Commit 9cfebed

Browse files
agraciokkoopa
authored andcommitted
Fixing an issue with SetAccessor() method passing incorrect parameter in v8 12.0
1 parent 590dab4 commit 9cfebed

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

nan.h

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2632,7 +2632,9 @@ NAN_DEPRECATED inline void SetAccessor(
26322632
, getter_
26332633
, setter_
26342634
, obj
2635-
#if !defined(V8_MAJOR_VERSION) || V8_MAJOR_VERSION < 12
2635+
#if defined(V8_MAJOR_VERSION) && (V8_MAJOR_VERSION < 12 \
2636+
|| (V8_MAJOR_VERSION == 12 && defined(V8_MINOR_VERSION) \
2637+
&& V8_MINOR_VERSION == 0))
26362638
, settings
26372639
#endif
26382640
, attribute
@@ -2686,7 +2688,9 @@ inline void SetAccessor(
26862688
, getter_
26872689
, setter_
26882690
, obj
2689-
#if !defined(V8_MAJOR_VERSION) || V8_MAJOR_VERSION < 12
2691+
#if defined(V8_MAJOR_VERSION) && (V8_MAJOR_VERSION < 12 \
2692+
|| (V8_MAJOR_VERSION == 12 && defined(V8_MINOR_VERSION) \
2693+
&& V8_MINOR_VERSION == 0))
26902694
, settings
26912695
#endif
26922696
, attribute

0 commit comments

Comments
 (0)