Skip to content

Commit 0a2177d

Browse files
romandevmhdawson
authored andcommitted
Fix test failures on linuxOne and AIX
Currently, the test only considers little endian. So, this patch adds a endian check function(IsLittleEndian()) and then use it instead of hardcoded value. Fixes: #230 PR-URL: #232 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent d567f4b commit 0a2177d

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

test/dataview/dataview_read_write.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,18 @@ function test(binding) {
1919
eval(`binding.dataview_read_write.set${type}(dataview, offset, value)`);
2020
}
2121

22+
function isLittleEndian() {
23+
const buffer = new ArrayBuffer(2);
24+
new DataView(buffer).setInt16(0, 256, true /* littleEndian */);
25+
return new Int16Array(buffer)[0] === 256;
26+
}
27+
2228
function jsReadDataView(dataview, type, offset, value) {
23-
return eval(`dataview.get${type}(offset, true)`);
29+
return eval(`dataview.get${type}(offset, isLittleEndian())`);
2430
}
2531

2632
function jsWriteDataView(dataview, type, offset, value) {
27-
eval(`dataview.set${type}(offset, value, true)`);
33+
eval(`dataview.set${type}(offset, value, isLittleEndian())`);
2834
}
2935

3036
function testReadData(dataview, type, offset, value) {

0 commit comments

Comments
 (0)