Skip to content

Commit 15e4b35

Browse files
kfarnungmhdawson
authored andcommitted
test: fix MSVC warning C4244 in tests
Fixes `warning C4244: 'argument': conversion from '::size_t' to 'double', possible loss of data` issues in `number` and `dataview` tests. PR-URL: #236 Reviewed-By: Michael Dawson <[email protected]>
1 parent 7f3ca03 commit 15e4b35

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

test/basic_types/number.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ Value ToUint32(const CallbackInfo& info) {
1313
}
1414

1515
Value ToInt64(const CallbackInfo& info) {
16-
return Number::New(info.Env(), info[0].As<Number>().Int64Value());
16+
return Number::New(info.Env(),
17+
static_cast<double>(info[0].As<Number>().Int64Value()));
1718
}
1819

1920
Value ToFloat(const CallbackInfo& info) {

test/dataview/dataview.cc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,13 @@ static Value GetArrayBuffer(const CallbackInfo& info) {
2525
}
2626

2727
static Value GetByteOffset(const CallbackInfo& info) {
28-
return Number::New(info.Env(), info[0].As<DataView>().ByteOffset());
28+
return Number::New(info.Env(),
29+
static_cast<double>(info[0].As<DataView>().ByteOffset()));
2930
}
3031

3132
static Value GetByteLength(const CallbackInfo& info) {
32-
return Number::New(info.Env(), info[0].As<DataView>().ByteLength());
33+
return Number::New(info.Env(),
34+
static_cast<double>(info[0].As<DataView>().ByteLength()));
3335
}
3436

3537
Object InitDataView(Env env) {

0 commit comments

Comments
 (0)