fix

Author: gabrielschulhof

.github/workflows/ci-win.yml

@@ -13,7 +13,10 @@ jobs:
     timeout-minutes: 30
     strategy:
       matrix:
-        node-version: [ 18.x, 20.x, 21.x ]
+        node-version:
+          # - 18.x (disabled)
+          - 20.x
+          - 21.x
         architecture: [x64, x86]
         os:
           - windows-2019

.github/workflows/ci.yml

@@ -17,7 +17,7 @@ jobs:
           - standard
           - experimental
         node-version:
-          - 18.x
+          # - 18.x (disabled because the newest version is unavailable)
           - 20.x
           - 21.x
           - 22.x

test/threadsafe_function/threadsafe_function_existing_tsfn.cc

@@ -86,7 +86,7 @@ static Value TestCall(const CallbackInfo& info) {
                                       0,
                                       1,
                                       nullptr, /*finalize data*/
-                                      TSFN_FINALIZER(FinalizeCB),
+                                      FinalizeCB,
                                       testContext,
                                       hasData ? CallJSWithData : CallJSNoData,
                                       &testContext->tsfn);

test/typed_threadsafe_function/typed_threadsafe_function_existing_tsfn.cc

@@ -88,7 +88,7 @@ static Value TestCall(const CallbackInfo& info) {
                                       0,
                                       1,
                                       nullptr, /*finalize data*/
-                                      TSFN_FINALIZER(FinalizeCB),
+                                      FinalizeCB,
                                       testContext,
                                       hasData ? CallJSWithData : CallJSNoData,
                                       &testContext->tsfn);