Address comments in 8 Jun 2024 Node-API meeting:

- Use post finalizer to delete reference in `~Reference`
- Remove const ref from comparison operator in `NogcEnv`
- Remove leftover debugging statements

Author: KevinEady

napi-inl.h

@@ -3244,15 +3244,19 @@ inline Reference<T>::Reference(napi_env env, napi_ref ref)
 
 template <typename T>
 inline Reference<T>::~Reference() {
-#ifndef NODE_API_EXPERIMENTAL_HAS_POST_FINALIZER
   if (_ref != nullptr) {
     if (!_suppressDestruct) {
+#ifdef NODE_API_EXPERIMENTAL_HAS_POST_FINALIZER
+      Env().AddPostFinalizer(
+          [](Napi::Env env, napi_ref ref) { napi_delete_reference(env, ref); },
+          _ref);
+#else
       napi_delete_reference(_env, _ref);
+#endif
     }
 
     _ref = nullptr;
   }
-#endif  // NODE_API_EXPERIMENTAL_HAS_POST_FINALIZER
 }
 
 template <typename T>

napi.h

@@ -345,7 +345,7 @@ class NogcEnv {
   bool operator==(const NogcEnv& other) const {
     return _env == other._env;
   };
-  bool operator==(const std::nullptr_t& /*other*/) const {
+  bool operator==(std::nullptr_t /*other*/) const {
     return _env == nullptr;
   };
 

test/movable_callbacks.cc

@@ -1,4 +1,3 @@
-#include <iostream>
 #include "napi.h"
 
 using namespace Napi;