Skip to content

Commit 5d6aeae

Browse files
legendecasmhdawson
authored andcommitted
build: enable travis for fast PR check
* test: remove unnecessary NAPI_EXPERIMENTAL * travis: remove chakracore on travis Reviewed-By: Michael Dawson <[email protected]>
1 parent 6192e70 commit 5d6aeae

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

.travis.yml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,20 +12,15 @@ env:
1212
# https://github.com/jasongin/nvs/blob/master/doc/CI.md
1313
- NVS_VERSION=1.4.2
1414
matrix:
15-
- NODEJS_VERSION=node/4
1615
- NODEJS_VERSION=node/6
1716
- NODEJS_VERSION=node/8
18-
- NODEJS_VERSION=node/9
1917
- NODEJS_VERSION=node/10
20-
- NODEJS_VERSION=chakracore/8
21-
- NODEJS_VERSION=chakracore/10
18+
- NODEJS_VERSION=node/12
2219
- NODEJS_VERSION=nightly
23-
- NODEJS_VERSION=chakracore-nightly
2420
matrix:
2521
fast_finish: true
2622
allow_failures:
2723
- env: NODEJS_VERSION=nightly
28-
- env: NODEJS_VERSION=chakracore-nightly
2924
sudo: false
3025
cache:
3126
directories:
@@ -59,7 +54,13 @@ install:
5954
script:
6055
# Travis CI sets NVM_NODEJS_ORG_MIRROR, but it makes node-gyp fail to download headers for nightly builds.
6156
- unset NVM_NODEJS_ORG_MIRROR
57+
- NODEJS_MAJOR_VERSION=$(node -p "process.versions.node.match(/\d+/)[0]")
6258

63-
- npm test $NPMOPT
59+
- |
60+
if [ ${NODEJS_MAJOR_VERSION} -gt 11 ]; then
61+
npm test
62+
else
63+
npm test $NPMOPT --NAPI_VERSION=$(node -p "process.versions.napi")
64+
fi
6465
after_success:
6566
- cpp-coveralls --gcov-options '\-lp' --build-root test/build --exclude test

test/basic_types/array.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#define NAPI_EXPERIMENTAL
21
#include "napi.h"
32

43
using namespace Napi;

0 commit comments

Comments
 (0)