chore: use eslint directly #1616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1616 +/- ##
=======================================
Coverage 66.35% 66.35%
=======================================
Files 3 3
Lines 2143 2143
Branches 703 703
=======================================
Hits 1422 1422
Misses 150 150
Partials 571 571 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hmm, should the formatting changes have been found in our "format everything" branch #1160 ? Or were there new rules added since 1160 landed (May 2022)? |
|
#1613 updated the eslint and plugins version. However, Both standard and neostandard have the rule 'object-shorthand' in their new versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tools/eslint-formatwas not failed on #1613 but failed on the main branch.Since the diff on applying the eslint is trivial, let's apply eslint on all files.